test: add P2PK support to MiniWallet
ClosedPublic
Actions

Authored by Fabien on Jul 2 2024, 12:12.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC185f0b1bcfac: test: add P2PK support to MiniWallet

Summary

This PR adds support for creating and spending transactions with raw pubkey (P2PK) outputs to MiniWallet

Backport of core#21945.
Only the changes to wallet.py are ported because we don't need it for feature_csv_activation.py.

Depends on D16405.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR21945

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29447
Build 58430: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 58429: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 2 2024, 12:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2024, 12:12

Fabien requested review of this revision.Jul 2 2024, 12:12

teamcity edited the summary of this revision. (Show Details)Jul 2 2024, 12:12

Fabien added a child revision: D16408: test: MiniWallet: introduce enum type for output mode.Jul 2 2024, 12:27

Skip size check for P2PK

Fabien planned changes to this revision.Jul 2 2024, 12:45

Harbormaster completed remote builds in B29443: Diff 48459.Jul 2 2024, 13:07

Fabien edited the summary of this revision. (Show Details)Jul 2 2024, 13:31

Fabien added a parent revision: D16405: test: use MiniWallet for feature_csv_activation.py.

Properly use sighash forkid

Harbormaster completed remote builds in B29445: Diff 48462.Jul 2 2024, 14:12

Harbormaster completed remote builds in B29447: Diff 48464.Jul 2 2024, 14:31

PiRK accepted this revision.Jul 2 2024, 14:37

PiRK added a subscriber: PiRK.

PiRK added inline comments.

test/functional/test_framework/wallet.py

121

I'm not sure why the bytearray is used here. It is probably not necessary. But it does not hurt either, afaict

$ python
Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> bytes([0, 1])
b'\x00\x01'
>>> bytes(bytearray([0, 1]))
b'\x00\x01'
>>>
>>> bytes(bytearray([0]))
b'\x00'
>>> bytes([0])
b'\x00'