Page MenuHomePhabricator
Differential D16484

[CI] Install nodejs with nvm instead of apt
DraftPublic
Actions

Authored by bytesofman on Jul 16 2024, 23:04.
This is a draft revision that has not yet been submitted for review.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

Current method of installing is brittle, as the setup script is not version pinned and can change (has twice now).

Here, we still install a setup script, but it is version pinned so (should) remain the same until we change node or nvm versions.

Test Plan

@bot cashtab-tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
node-install-improve
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningcontrib/utils/install-dependencies-bullseye.sh:166SC1090ShellCheck found an issue:
Unit
No Test Coverage
Build Status
Buildable 29595
Build 58725: Build Diff
Build 58724: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Harbormaster completed remote builds in B29601: Diff 48691.Jul 17 2024, 16:38
bytesofman added a comment.Jul 17 2024, 16:38

@bot ecash-herald-tests

teamcity updated a token.Jul 17 2024, 16:38
teamcity added a comment.Jul 17 2024, 16:56
Build Bitcoin ABC Diffs / Diff Testing (ecash-herald-tests) failed.

Tail of the build log:

Test depends on ecashaddrjs. Installing ecashaddrjs dependencies...
/work/modules/ecashaddrjs /work/abc-ci-builds/ecash-herald-tests
/work/abc-ci-builds/ecash-herald-tests/script.sh: line 21: npm: command not found
Build ecash-herald-tests failed with exit code 127
bytesofman updated this revision to Diff 48694.Jul 17 2024, 17:30

alias node to latest version installed

Harbormaster completed remote builds in B29603: Diff 48694.Jul 17 2024, 17:30
bytesofman added a comment.Jul 17 2024, 17:30

@bot ecash-herald-tests

teamcity updated a token.Jul 17 2024, 17:30
teamcity added a comment.Jul 17 2024, 17:49
Build Bitcoin ABC Diffs / Diff Testing (ecash-herald-tests) failed.

Tail of the build log:

Test depends on ecashaddrjs. Installing ecashaddrjs dependencies...
/work/modules/ecashaddrjs /work/abc-ci-builds/ecash-herald-tests
/work/abc-ci-builds/ecash-herald-tests/script.sh: line 21: npm: command not found
Build ecash-herald-tests failed with exit code 127
bytesofman updated this revision to Diff 48699.Jul 17 2024, 18:09

use tarball instead of nvm

Harbormaster completed remote builds in B29607: Diff 48699.Jul 17 2024, 18:09
bytesofman updated this revision to Diff 48700.Jul 17 2024, 18:10

double quotes for lint

Harbormaster completed remote builds in B29608: Diff 48700.Jul 17 2024, 18:10
bytesofman added a comment.Jul 17 2024, 18:10

@bot ecash-herald-tests

teamcity updated a token.Jul 17 2024, 18:10
teamcity added a comment.Jul 17 2024, 19:00
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman updated this revision to Diff 48748.Jul 19 2024, 18:17

update path syntax with escape characters and quotes, back out combined source command

Harbormaster completed remote builds in B29639: Diff 48748.Jul 19 2024, 18:17
bytesofman added a comment.Jul 19 2024, 18:18

@bot ecash-herald-tests

teamcity updated a token.Jul 19 2024, 18:18
teamcity added a comment.Jul 19 2024, 18:22
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman updated this revision to Diff 48749.Jul 19 2024, 18:34

verbose tar unpacking to check, match path syntax of python install above

Harbormaster completed remote builds in B29640: Diff 48749.Jul 19 2024, 18:35
bytesofman updated this revision to Diff 48750.Jul 19 2024, 18:35

add debug log

Harbormaster completed remote builds in B29641: Diff 48750.Jul 19 2024, 18:35
bytesofman added a comment.Jul 19 2024, 18:36

@bot ecash-herald-tests

teamcity updated a token.Jul 19 2024, 18:36
teamcity added a comment.Jul 19 2024, 18:40
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman updated this revision to Diff 48751.Jul 19 2024, 21:52

remove debug log, remove ':' after $PATH, add absolute path with /root

Harbormaster completed remote builds in B29642: Diff 48751.Jul 19 2024, 21:52
bytesofman added a comment.Jul 19 2024, 21:52

@bot ecash-herald-tests

teamcity updated a token.Jul 19 2024, 21:52
teamcity added a comment.Jul 19 2024, 21:57
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Fabien added a comment.Aug 16 2024, 15:40

@bot ecash-herald-tests

teamcity updated a token.Aug 16 2024, 15:40
teamcity added a comment.Aug 16 2024, 15:48
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman updated this revision to Diff 49261.Aug 16 2024, 17:54

try with nvm

Harbormaster completed remote builds in B30014: Diff 49261.Aug 16 2024, 17:54
bytesofman added a comment.Aug 16 2024, 17:54

@bot ecash-herald-tests

teamcity updated a token.Aug 16 2024, 17:54
teamcity added a comment.Aug 16 2024, 18:05
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman updated this revision to Diff 49262.Aug 16 2024, 18:06

patch typo for install script

Harbormaster completed remote builds in B30015: Diff 49262.Aug 16 2024, 18:06
bytesofman added a comment.Aug 16 2024, 18:07

@bot ecash-herald-tests

teamcity updated a token.Aug 16 2024, 18:07
teamcity added a comment.Aug 16 2024, 18:12
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman updated this revision to Diff 49264.Aug 16 2024, 18:31

adding debug logging and permissions check logging

Harbormaster completed remote builds in B30017: Diff 49264.Aug 16 2024, 18:31
bytesofman updated this revision to Diff 49265.Aug 16 2024, 18:32

debug logging, lint

Harbormaster completed remote builds in B30018: Diff 49265.Aug 16 2024, 18:32
bytesofman added a comment.Aug 16 2024, 18:32

@bot ecash-herald-tests

teamcity updated a token.Aug 16 2024, 18:32
teamcity added a comment.Aug 16 2024, 18:36
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman updated this revision to Diff 49266.Aug 16 2024, 18:40

improve debug logging

Harbormaster completed remote builds in B30019: Diff 49266.Aug 16 2024, 18:40
bytesofman added a comment.Aug 16 2024, 18:40

@bot ecash-herald-tests

teamcity updated a token.Aug 16 2024, 18:40
teamcity added a comment.Aug 16 2024, 18:54
Build Bitcoin ABC Diffs / Diff Testing (ecash-herald-tests) failed.

Tail of the build log:

Test depends on ecashaddrjs. Installing ecashaddrjs dependencies...
/work/modules/ecashaddrjs /work/abc-ci-builds/ecash-herald-tests
/work/abc-ci-builds/ecash-herald-tests/script.sh: line 21: npm: command not found
Build ecash-herald-tests failed with exit code 127
bytesofman updated this revision to Diff 49267.Aug 16 2024, 19:08

another test

Harbormaster completed remote builds in B30020: Diff 49267.Aug 16 2024, 19:08
bytesofman added a comment.Aug 16 2024, 19:08

@bot ecash-herald-tests

teamcity updated a token.Aug 16 2024, 19:08
teamcity added a comment.Aug 16 2024, 19:12
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Fabien added a comment.Aug 16 2024, 19:40

@bot ecash-herald-tests

teamcity updated a token.Aug 16 2024, 19:40
teamcity added a comment.Aug 16 2024, 19:45
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman updated this revision to Diff 49269.Aug 16 2024, 19:45

remove intentional failure and debug logging from the setup script

Harbormaster completed remote builds in B30022: Diff 49269.Aug 16 2024, 19:45
bytesofman added a comment.Aug 16 2024, 19:46

@bot ecash-herald-tests

teamcity updated a token.Aug 16 2024, 19:46
teamcity added a comment.Aug 16 2024, 19:59
Build Bitcoin ABC Diffs / Diff Testing (ecash-herald-tests) failed.

Tail of the build log:

Test depends on ecashaddrjs. Installing ecashaddrjs dependencies...
/work/modules/ecashaddrjs /work/abc-ci-builds/ecash-herald-tests
/work/abc-ci-builds/ecash-herald-tests/script.sh: line 21: npm: command not found
Build ecash-herald-tests failed with exit code 127
bytesofman updated this revision to Diff 49270.Aug 16 2024, 20:06

echo $PATH in js-mocha

Harbormaster completed remote builds in B30023: Diff 49270.Aug 16 2024, 20:06
bytesofman updated this revision to Diff 49271.Aug 16 2024, 20:07

add whoami

Harbormaster completed remote builds in B30024: Diff 49271.Aug 16 2024, 20:07
bytesofman added a comment.Aug 16 2024, 20:07

@bot ecash-herald-tests

teamcity updated a token.Aug 16 2024, 20:07
Build Bitcoin ABC Diffs / Diff Testing (ecash-herald-tests) failed.

Tail of the build log:

/root/.cargo/bin:/work/node-v20.15.1-linux-x64/bin:/root/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
root
Test depends on ecashaddrjs. Installing ecashaddrjs dependencies...
/work/modules/ecashaddrjs /work/abc-ci-builds/ecash-herald-tests
/work/abc-ci-builds/ecash-herald-tests/script.sh: line 25: npm: command not found
Build ecash-herald-tests failed with exit code 127
bytesofman updated this revision to Diff 49272.Aug 16 2024, 20:20

use $HOME in install dir

Harbormaster completed remote builds in B30025: Diff 49272.Aug 16 2024, 20:20
bytesofman added a comment.Aug 16 2024, 20:20

@bot ecash-herald-tests

teamcity updated a token.Aug 16 2024, 20:20
teamcity added a comment.Aug 16 2024, 20:34
Build Bitcoin ABC Diffs / Diff Testing (ecash-herald-tests) failed.

Tail of the build log:

/root/.cargo/bin:/work/node-v20.15.1-linux-x64/bin:/root/.local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
root
Test depends on ecashaddrjs. Installing ecashaddrjs dependencies...
/work/modules/ecashaddrjs /work/abc-ci-builds/ecash-herald-tests
/work/abc-ci-builds/ecash-herald-tests/script.sh: line 25: npm: command not found
Build ecash-herald-tests failed with exit code 127

Revision Contents
Changeset List

PathSize
contrib/
utils/
13 lines

Diff 48684

View Options

contrib/utils/install-dependencies-bullseye.sh

Loading...