Page MenuHomePhabricator

Get rid of ConnectTrace
ClosedPublic

Authored by Fabien on Jul 27 2024, 21:32.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC12f60ab72be7: Get rid of ConnectTrace
Summary

This class is no longer used for anything useful since the validation interface has split SyncTransaction() into TransactionAddedToMempool(), BlockConncted() and BlockDisconnected(). Getting rid of the legacy class simplifies the code a bit. The only change in behavior is that the block connection signals are sent prior to the transactions added to mempool in case of a reorg, which is more correct anyway.

Depends on D16538.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien published this revision for review.Jul 30 2024, 20:11
This revision is now accepted and ready to land.Jul 30 2024, 20:22
This revision was automatically updated to reflect the committed changes.