Page MenuHomePhabricator
Differential D1775

Add vConnect to CConnman::Options
ClosedPublic
Actions

Authored by deadalnix on Sep 12 2018, 14:18.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING6133a270ffa9: Add vConnect to CConnman::Options
rABC6133a270ffa9: Add vConnect to CConnman::Options
Summary

Split the "-connect" argument parsing out of CConnman and put it into
AppInitMain().

Backport core PR10596

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
corepr10596
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3300
Build 4684: Bitcoin ABC Buildbot (legacy)
Build 4683: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 12 2018, 14:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2018, 14:18
teamcity added a subscriber: teamcity.Sep 12 2018, 14:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D1776: add m_added_nodes to connman options.Sep 12 2018, 14:31
teamcity added a comment.Sep 12 2018, 14:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3283: Diff 4896.Sep 12 2018, 14:54
schancel accepted this revision.Sep 15 2018, 15:16
This revision is now accepted and ready to land.Sep 15 2018, 15:16
deadalnix updated this revision to Diff 4920.Sep 15 2018, 17:12

rebase

deadalnix updated this revision to Diff 4925.Sep 15 2018, 17:31

rebase

teamcity added a comment.Sep 15 2018, 17:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3300: Diff 4920.Sep 15 2018, 18:23
teamcity added a comment.Sep 15 2018, 18:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

teamcity added a comment.Sep 15 2018, 18:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Closed by commit rABC6133a270ffa9: Add vConnect to CConnman::Options (authored by Marko Bencun <marko.bencun@monetas.net>, committed by deadalnix). · Explain WhySep 15 2018, 18:42
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Sep 15 2018, 19:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3302: Diff 4925.Sep 15 2018, 19:00

Revision Contents
Changeset List

PathSize
src/
9 lines
4 lines
24 lines

Diff 4920

View Options

src/init.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...