Page MenuHomePhabricator
Differential D16626

[Explorer] Update readme with additional dependency
ClosedPublic
Actions

Authored by emack on Aug 12 2024, 15:03.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCb1cbec841bc7: [Explorer] Update readme with additional dependency
Summary

When running the explorer locally I needed sudo apt install pkg-config in addition to the existing two dependencies in the readme.

Test Plan

proof read

Diff Detail

Repository
rABC Bitcoin ABC
Branch
explorerDependency
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29977
Build 59488: Build Diff
Build 59487: arc lint + arc unit

Event Timeline

emack created this revision.Aug 12 2024, 15:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 12 2024, 15:03
emack requested review of this revision.Aug 12 2024, 15:03
Harbormaster completed remote builds in B29942: Diff 49152.Aug 12 2024, 15:03
bytesofman requested changes to this revision.Aug 12 2024, 16:22
bytesofman added inline comments.
web/explorer/README.md
12 ↗(On Diff #49152)

not sure I needed this tho I am on ubuntu

would specify your experience here

If running <ubuntu at this version>, you may also need `pkg-config`. Install with `sudo apt install pkg-config`
This revision now requires changes to proceed.Aug 12 2024, 16:22
emack updated this revision to Diff 49203.Aug 14 2024, 00:53

Updated dependency

Harbormaster completed remote builds in B29977: Diff 49203.Aug 14 2024, 00:53
bytesofman accepted this revision.Aug 14 2024, 03:28
This revision is now accepted and ready to land.Aug 14 2024, 03:28
Closed by commit rABCb1cbec841bc7: [Explorer] Update readme with additional dependency (authored by emack). · Explain WhyAug 14 2024, 04:21
This revision was automatically updated to reflect the committed changes.
emack added a commit: rABCb1cbec841bc7: [Explorer] Update readme with additional dependency.

Revision Contents
Changeset List

PathSize
web/
explorer/
2 lines

Diff 49203

View Options

web/explorer/README.md

Loading...