Page MenuHomePhabricator
Differential D1790

Refactor duplicate input check
ClosedPublic
Actions

Authored by deadalnix on Sep 17 2018, 21:58.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING7e2047989308: Refactor duplicate input check
rABC7e2047989308: Refactor duplicate input check
Summary
  • Use std::unordered_set instead of std::set.
  • Do not try to check duplicate input for coinbase.
  • Always check duplicate input for regular transactions.
Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
checkinput
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3320
Build 4723: Bitcoin ABC Buildbot (legacy)
Build 4722: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 17 2018, 21:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2018, 21:58
teamcity added a subscriber: teamcity.Sep 17 2018, 21:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel accepted this revision.Sep 17 2018, 22:04
This revision is now accepted and ready to land.Sep 17 2018, 22:04
deadalnix updated this revision to Diff 4954.Sep 17 2018, 22:20

Just always check

deadalnix edited the summary of this revision. (Show Details)Sep 17 2018, 22:21
teamcity added a comment.Sep 17 2018, 22:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Closed by commit rABC7e2047989308: Refactor duplicate input check (authored by deadalnix). · Explain WhySep 17 2018, 22:22
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Sep 17 2018, 22:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3319: Diff 4953.Sep 17 2018, 22:34
Harbormaster completed remote builds in B3320: Diff 4954.Sep 17 2018, 22:59
teamcity added a comment.Sep 17 2018, 22:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Revision Contents
Changeset List

PathSize
src/
consensus/
6 lines
31 lines
test/
6 lines
10 lines

Diff 4954

View Options

src/consensus/tx_verify.h

Loading...
View Options

src/consensus/tx_verify.cpp

Loading...
View Options

src/test/sigopcount_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...