Details
Details
- Reviewers
bytesofman Fabien - Group Reviewers
Restricted Project - Commits
- rABC8c8c101739ff: [ecash-agora] Partial Agora offers: Add SLP support to plugin, `Agora` and…
npm run integration-tests
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ecash-agora-partial-offer-slp
- Lint
Lint Errors Severity Location Code Message Error modules/ecash-agora/agora.py:20 F401 flake8 F401 Error modules/ecash-agora/agora.py:20 F401 flake8 F401 Error modules/ecash-agora/agora.py:20 F401 flake8 F401 Error modules/ecash-agora/agora.py:20 F401 flake8 F401 - Unit
No Test Coverage - Build Status
Buildable 30249 Build 60025: Build Diff ecash-agora-integration-tests Build 60024: arc lint + arc unit
Event Timeline
modules/ecash-agora/tests/partial.slp.bigsats.test.ts | ||
---|---|---|
157 ↗ | (On Diff #49657) | isn't this the 2nd output? |
161 ↗ | (On Diff #49657) | isn't this the third output? |
244 ↗ | (On Diff #49657) | same question as above -- what is outputs[0] ? |
modules/ecash-agora/tests/partial.test.slp.ts | ||
1 ↗ | (On Diff #49657) | so we have partial.slp.test.ts and also partial.test.slp.ts ? I can't really tell from the naming what I should expect to find in each file / why they are distinct. |
modules/ecash-agora/tests/partial.slp.bigsats.test.ts | ||
---|---|---|
157 ↗ | (On Diff #49657) | yeah well the OP_RETURN is the 0th output 🙃 You would've hoped there's a convention for this already, but I can change it for clarity |
244 ↗ | (On Diff #49657) | outputs[0] is the OP_RETURN |
modules/ecash-agora/tests/partial.test.slp.ts | ||
1 ↗ | (On Diff #49657) | Good point—maybe call it partial-helpers-slp.ts, or something else |
modules/ecash-agora/src/agora.ts | ||
---|---|---|
206 ↗ | (On Diff #49657) | I think the else has two good reasons:
|
399 ↗ | (On Diff #49657) | same reason here |
modules/ecash-agora/agora.py | ||
---|---|---|
399 ↗ | (On Diff #49657) |