Page MenuHomePhabricator

[ecash-agora] Limit token truncation level to 5 (SLP) and 3 (ALP)
ClosedPublic

Authored by tobias_ruck on Sep 12 2024, 23:09.

Details

Summary

For ALP, the estimation often results in truncating 4 or more bytes, which is not supported in the Script, therefore we limit it to 3.

We also limit SLP to 5 bytes (which is also the maximum). There's currently no known set of parameters that would result in 6 bytes of truncation, but it's an important failsafe.

Depends on D16753.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-agora-partial-approx-alp
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30274
Build 60075: Build Diffecash-agora-tests · ecash-agora-integration-tests
Build 60074: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 13 2024, 10:06