Page MenuHomePhabricator
Differential D16775

[Cashtab] Filter token list by token type
ClosedPublic
Actions

Authored by bytesofman on Sep 17 2024, 23:58.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC0d5d1751c2c9: [Cashtab] Filter token list by token type
Summary

We need some way of showing only Collections, only NFTs, only fungible tokens -- ticker-only search is not good enough.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sort-tokens-by-type
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30337
Build 60200: Build Diffecash-lib-tests · cashtab-tests
Build 60199: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sep 17 2024, 23:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2024, 23:58
Harbormaster completed remote builds in B30336: Diff 49698.Sep 18 2024, 00:02
bytesofman updated this revision to Diff 49699.Sep 18 2024, 04:00

simplified approach with switches, do not allow filtering for multiple types

bytesofman updated this revision to Diff 49700.Sep 18 2024, 04:03

better comments, clean up debug comments

Harbormaster completed remote builds in B30337: Diff 49699.Sep 18 2024, 04:04
Harbormaster completed remote builds in B30338: Diff 49700.Sep 18 2024, 04:07
bytesofman published this revision for review.Sep 18 2024, 04:09
emack accepted this revision.Sep 18 2024, 05:45
This revision is now accepted and ready to land.Sep 18 2024, 05:45
Closed by commit rABC0d5d1751c2c9: [Cashtab] Filter token list by token type (authored by bytesofman). · Explain WhySep 18 2024, 12:25
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC0d5d1751c2c9: [Cashtab] Filter token list by token type.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Etokens/
201 lines
__tests__/
69 lines
fixtures/
112 lines

Diff 49699

View Options

cashtab/src/components/Etokens/Etokens.js

Loading...
View Options

cashtab/src/components/Etokens/__tests__/Etokens.test.js

Loading...
View Options

cashtab/src/components/Etokens/fixtures/mocks.js

Loading...