Support the chronik functionality introduced in D16696 in chronik-client
Details
Details
- Reviewers
tobias_ruck - Group Reviewers
Restricted Project - Commits
- rABC87174b963d77: [chronik-client] Support websocket subscriptions to plugins
CI for chronik-client integration tests
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cc-plugin-ws-subs
- Lint
Lint Warnings Severity Location Code Message Warning test/functional/setup_scripts/chronik-client_plugins.py:114 W293 flake8 W293 Warning test/functional/setup_scripts/chronik-client_plugins.py:177 W291 flake8 W291 Warning test/functional/setup_scripts/chronik-client_plugins.py:279 W293 flake8 W293 - Unit
No Test Coverage - Build Status
Event Timeline
Comment Actions
correct test script to match resolved mempool bugs, add validation for plugin subs, test plugin subs and unsubs, clean up logs
Comment Actions
otherwise lgtm
| modules/chronik-client/src/ChronikClient.ts | ||
|---|---|---|
| 765 ↗ | (On Diff #49725) | eventually we should abstract this for all subscription types but not in this diff |
| modules/chronik-client/src/validation.ts | ||
| 75 ↗ | (On Diff #49725) | is there a reason for the "first parameter"? since it's an object and not a list |
| 83 ↗ | (On Diff #49725) | same here |
| 89 ↗ | (On Diff #49725) | and here |
| modules/chronik-client/src/validation.ts | ||
|---|---|---|
| 75 ↗ | (On Diff #49725) | In this case, the user only sees this error msg by calling subscribeToPlugin(pluginName, group) case to be made that all subscription functions should be more like subscribeTo<Thing>(objectOfExpectedShape), e.g. in this case subscribeToPlugin({pluginName: <name>, group: <group>}) -- that is not currently the API tho (subscribeToScript is like this as well). That said ... yeah I don't think "first parameter" is really helping. If we do truly need it, good sign the API needs to be changed. |