Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC1653ee01bb8c: [Chronik] Clear OP_RETURN scripts from script index, enable DB upgrade to…

Summary

Deletes all OP_RETURN scripts from the DB (using ranges). Also report on oversized (and thus unspendable Scripts). We might want to not add those to the DB in the future, too.

Also, we enable the DB upgrade to version 13, this is currently disabled until all upgrades are in place.

This way, we have all three upgrades in one batch:

Add the missing MINT VAULT txs (patched out in D16916), using the (later deleted) OP_RETURNs still indexed in the DB
Fixing invalidly compressed P2PK scripts (patched out in D16899)
Removing the OP_RETURN scripts (patched out in D16917)

Depends on D16938.

Test Plan

Make a backup of the Chronik DB
Build using ninja
Run node (using -debug=chronik), it should upgrade automatically to 13
It should now update first the MINT VAULT txs, then the P2PK scripts, then remove the OP_RETURNs

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-remove-opreturn-scripts

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30693
Build 60902: Build Diff	ecash-lib-integration-tests · chronik-client-integration-tests · build-chronik · build-chronik-plugins · ecash-agora-integration-tests
Build 60901: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Oct 19 2024, 22:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 19 2024, 22:41

Harbormaster completed remote builds in B30682: Diff 50213.Oct 19 2024, 22:48

Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.

Tail of the build log:

   Doc-tests chronik-bridge

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-db

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-http

running 1 test
test chronik/chronik-http/src/protobuf.rs - protobuf::Protobuf (line 29) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.33s

   Doc-tests chronik-indexer

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-common

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-impl

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-proto

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-util

running 2 tests
test chronik/chronik-util/src/log.rs - log::log (line 65) ... ignored
test chronik/chronik-util/src/log.rs - log::log_chronik (line 87) ... ignored

test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.00s

ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.

Tail of the build log:

    Checking chronik-plugin-common v0.1.0 (/work/chronik/chronik-plugin-common)
    Checking chronik-plugin v0.1.0 (/work/chronik/chronik-plugin)
    Checking toml_datetime v0.6.6
    Checking serde_spanned v0.6.6
   Compiling prost-build v0.11.9
   Compiling pyo3 v0.22.2
    Checking sync_wrapper v0.1.2
    Checking seahash v4.1.0
    Checking winnow v0.6.13
    Checking mime v0.3.17
    Checking hyper v1.2.0
    Checking topo_sort v0.4.0
    Checking axum-core v0.4.3
    Checking tower v0.4.13
    Checking tokio-tungstenite v0.21.0
    Checking memoffset v0.9.1
    Checking serde_json v1.0.115
    Checking serde_urlencoded v0.7.1
    Checking hyper-util v0.1.3
    Checking futures-executor v0.3.30
    Checking serde_path_to_error v0.1.16
    Checking unindent v0.2.3
    Checking sync_wrapper v1.0.1
    Checking matchit v0.7.3
    Checking base64 v0.21.7
    Checking unicode-segmentation v1.11.0
    Checking futures v0.3.30
    Checking tower-http v0.5.2
   Compiling chronik-proto v0.1.0 (/work/chronik/chronik-proto)
    Checking convert_case v0.6.0
    Checking toml_edit v0.22.14
   Compiling chronik-bridge v0.1.0 (/work/chronik/chronik-bridge)
   Compiling librocksdb-sys v0.11.0+8.1.1
    Checking axum v0.7.5
   Compiling pyo3-macros v0.22.2
    Checking toml v0.8.14
    Checking chronik-plugin-impl v0.1.0 (/work/chronik/chronik-plugin-impl)
    Checking rocksdb v0.21.0
    Checking chronik-db v0.1.0 (/work/chronik/chronik-db)
error: mutable key type
   --> chronik/chronik-db/src/io/upgrade.rs:219:9
    |
219 |         let mut scripts_not_to_upgrade = HashSet::new();
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type
    = note: `-D clippy::mutable-key-type` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::mutable_key_type)]`

error: mutable key type
   --> chronik/chronik-db/src/io/upgrade.rs:220:9
    |
220 |         let mut scripts_to_upgrade = HashSet::new();
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type

error: could not compile `chronik-db` (lib) due to 2 previous errors
ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik-plugins failed with exit code 1

fix clippy lint

Harbormaster completed remote builds in B30687: Diff 50219.Oct 19 2024, 23:51

rebase

tobias_ruck published this revision for review.Oct 20 2024, 00:15

Harbormaster completed remote builds in B30693: Diff 50227.Oct 20 2024, 00:34

PiRK accepted this revision.Oct 20 2024, 08:17

This revision is now accepted and ready to land.Oct 20 2024, 08:17

tobias_ruck mentioned this in D16936: [Chronik] Automatically fix MINT VAULT txs.Oct 21 2024, 07:30

rebase on D16938.

tobias_ruck mentioned this in rABCaa5e92acc72b: [Chronik] Automatically fix MINT VAULT txs.Oct 22 2024, 08:38

Harbormaster completed remote builds in B30725: Diff 50267.Oct 22 2024, 08:44

Closed by commit rABC1653ee01bb8c: [Chronik] Clear OP_RETURN scripts from script index, enable DB upgrade to… (authored by tobias_ruck). · Explain WhyOct 22 2024, 08:54