Page MenuHomePhabricator
Differential D16899

[chronik] fix script compression
ClosedPublic
Actions

Authored by PiRK on Oct 12 2024, 12:38.

Details

Reviewers
Fabien
tobias_ruck
Group Reviewers
Restricted Project
Commits
rABC4c73e2329958: [chronik] fix script compression
Summary

Some non-standard PUSH33 data CHECKSIG and PUSH65 data CHECKSIG where data is not a valid pubkey were incorrectly wrapped as P2PK, which caused the compressed script to be wrong in the db.

This fixes the compression for new keys. The existing db can be fixed in a separate diff if we decide it is necessary.

Test Plan

ninja check-all check-crates

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 12 2024, 12:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2024, 12:38
PiRK requested review of this revision.Oct 12 2024, 12:38
PiRK edited the summary of this revision. (Show Details)Oct 12 2024, 12:39
PiRK added inline comments.Oct 12 2024, 12:43
chronik/bitcoinsuite-core/src/script/script.rs
354–370 ↗(On Diff #50066)

not sure if this test really makes sense or if Script::p2pk_uncompressed should inspect the pattern and panic in this case. Same for not_comp_pk below.

Harbormaster completed remote builds in B30574: Diff 50066.Oct 12 2024, 13:01
Fabien accepted this revision.Oct 14 2024, 20:51
Fabien added a subscriber: Fabien.
Fabien added inline comments.
chronik/bitcoinsuite-core/src/script/script.rs
354–370 ↗(On Diff #50066)

I think it's fine to not panic here as the output is correct anyway even with the unexpected input

This revision is now accepted and ready to land.Oct 14 2024, 20:51
tobias_ruck accepted this revision.Oct 14 2024, 20:59
tobias_ruck added a subscriber: tobias_ruck.
tobias_ruck added inline comments.
chronik/bitcoinsuite-core/src/script/script.rs
430 ↗(On Diff #50066)
PiRK updated this revision to Diff 50103.Oct 15 2024, 06:49

-,

Harbormaster completed remote builds in B30599: Diff 50103.Oct 15 2024, 07:13
Closed by commit rABC4c73e2329958: [chronik] fix script compression (authored by PiRK). · Explain WhyOct 15 2024, 07:47
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4c73e2329958: [chronik] fix script compression.
tobias_ruck mentioned this in D16916: [Chronik] Fix bug in MINT VAULT indexing.Oct 16 2024, 08:07
tobias_ruck mentioned this in rABC3d229b849ce0: [Chronik] Fix bug in MINT VAULT indexing.Oct 16 2024, 11:23
tobias_ruck mentioned this in D16941: [Chronik] Clear OP_RETURN scripts from script index, enable DB upgrade to version 13.Oct 19 2024, 22:41
tobias_ruck mentioned this in rABC1653ee01bb8c: [Chronik] Clear OP_RETURN scripts from script index, enable DB upgrade to….Oct 22 2024, 08:54

Revision Contents
Changeset List

PathSize
chronik/
bitcoinsuite-core/
src/
script/
106 lines

Diff 50105

View Options

chronik/bitcoinsuite-core/src/script/script.rs

Loading...