Paths

Table of Contentst

Differential D16968

[secp256k1] Backport "'Schnorrsig API overhaul' fixups"
ClosedPublic
Actions

Authored by tobias_ruck on Oct 23 2024, 16:11.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC79b2e673791c: [secp256k1] Backport "'Schnorrsig API overhaul' fixups"

Summary

Bitcoin Core added some later fixups, which make sense to be backported after we added D16958.

This is a backport of secp256k1#963.

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Branch

secp256k1-backport-PR963

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30784
Build 61082: Build Diff	lint-circular-dependencies · build-without-wallet · build-ecash-secp256k1 · build-secp256k1-bench · build-secp256k1-java · build-secp256k1 · build-diff · build-debug · build-clang-tidy · build-clang
Build 61081: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Oct 23 2024, 16:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2024, 16:11

tobias_ruck requested review of this revision.Oct 23 2024, 16:11

teamcity edited the summary of this revision. (Show Details)Oct 23 2024, 16:11

Harbormaster completed remote builds in B30763: Diff 50317.Oct 23 2024, 16:33

Fabien requested changes to this revision.Oct 23 2024, 20:32

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/secp256k1/ci/linux-debian.Dockerfile
12 ↗	(On Diff #50317)	This is all that is needed, you went a bit too far here :)

This revision now requires changes to proceed.Oct 23 2024, 20:32

tobias_ruck added inline comments.Oct 23 2024, 20:39

src/secp256k1/ci/linux-debian.Dockerfile
12 ↗	(On Diff #50317)	ah, well I just ported what they had, but that makes more sense :)

remove unneeded installs

Fabien accepted this revision.Oct 23 2024, 20:44

This revision is now accepted and ready to land.Oct 23 2024, 20:44

Harbormaster completed remote builds in B30782: Diff 50341.Oct 23 2024, 20:56

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

rebase onto master

Harbormaster completed remote builds in B30784: Diff 50343.Oct 23 2024, 21:35

Closed by commit rABC79b2e673791c: [secp256k1] Backport "'Schnorrsig API overhaul' fixups" (authored by tobias_ruck). · Explain WhyOct 23 2024, 22:22

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC79b2e673791c: [secp256k1] Backport "'Schnorrsig API overhaul' fixups".

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

21 lines

ci/

linux-debian.Dockerfile

1 line

include/

secp256k1_schnorrsig.h

2 lines

src/

1 line

1 line

modules/

schnorrsig/

4 lines

4 lines

Diff 50343

src/secp256k1/.cirrus.yml

Loading...

src/secp256k1/ci/linux-debian.Dockerfile

Loading...

src/secp256k1/include/secp256k1_schnorrsig.h

Loading...

src/secp256k1/src/ecmult.h

Loading...

src/secp256k1/src/ecmult_gen.h

Loading...

src/secp256k1/src/modules/schnorrsig/main_impl.h

Loading...

src/secp256k1/src/modules/schnorrsig/tests_impl.h

Loading...