Page MenuHomePhabricator

Bump our clang toolchain to version 16
ClosedPublic

Authored by Fabien on Fri, Oct 25, 20:14.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCe50d1ee720e0: Bump our clang toolchain to version 16
Summary

This includes clang-16 as a compiler, but also clang-format-16 and clang-tidy-16 as linters.

Test Plan
arc lint --everything

Run the clang builds.

Event Timeline

Tail of the build log:

-- The C compiler identification is Clang 16.0.6
-- The CXX compiler identification is Clang 16.0.6
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Python: /usr/bin/python3.9 (found suitable version "3.9.2", minimum required is "3.9") found components: Interpreter 
-- Found Git: /usr/bin/git (found version "2.30.2") 
-- Using ccache: /usr/bin/ccache
CMake Error at cmake/modules/DoOrFail.cmake:4 (message):
  Failed to find program
  [clang-tidy;clang-tidy-13;clang-tidy-12;clang-tidy-11;clang-tidy-10],
  please make sure that it is installed and reachable through the system
  PATH.
Call Stack (most recent call first):
  cmake/modules/ClangTidy.cmake:3 (find_program_or_fail)
  src/CMakeLists.txt:94 (include)


-- Configuring incomplete, errors occurred!
See also "/work/abc-ci-builds/build-clang-tidy/CMakeFiles/CMakeOutput.log".
Build build-clang-tidy failed with exit code 1

Fix clang-tidy, fix weird char in contributing

@bot build-ubsan build-asan build-tsan

Fabien published this revision for review.Fri, Oct 25, 21:21
This revision is now accepted and ready to land.Sat, Oct 26, 07:44
This revision was automatically updated to reflect the committed changes.