Differential D17040

[herald] Always print the staking reward winner for invalidated blocks
ClosedPublic
Actions

Authored by Fabien on Tue, Oct 29, 20:18.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC6fccffff629a: [herald] Always print the staking reward winner for invalidated blocks

Summary

Even if the guessed reject reason has nothing to do with the staking rewards. In the event it cannot be determined (e.g. there is no such output) it simply prints 'unknown'.

Test Plan

npm run test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30910
Build 61323: Build Diff	ecash-herald-tests
Build 61322: arc lint + arc unit

Event Timeline

Fabien created this revision.Tue, Oct 29, 20:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Oct 29, 20:18

Fabien requested review of this revision.Tue, Oct 29, 20:18

Harbormaster completed remote builds in B30910: Diff 50538.Tue, Oct 29, 20:22

bytesofman accepted this revision.Tue, Oct 29, 22:40

This revision is now accepted and ready to land.Tue, Oct 29, 22:40

Closed by commit rABC6fccffff629a: [herald] Always print the staking reward winner for invalidated blocks (authored by Fabien). · Explain WhyWed, Oct 30, 08:54

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6fccffff629a: [herald] Always print the staking reward winner for invalidated blocks.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

events.js

19 lines

test/

mocks/

blockInvalidated.js

2 lines

Diff 50538

View Options

apps/ecash-herald/src/events.js