Differential D17071

[avalanche] Cleanup the logs
ClosedPublic
Actions

Authored by Fabien on Nov 4 2024, 16:35.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC00ed23b33c12: [avalanche] Cleanup the logs

Summary

Remove the messages that are not useful or redundant.

Depends on D17076.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_log_cleanup

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30999
Build 61501: Build Diff	build-debug · build-diff · build-without-wallet · lint-circular-dependencies · build-clang · build-clang-tidy
Build 61500: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 4 2024, 16:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 4 2024, 16:35

Fabien requested review of this revision.Nov 4 2024, 16:35

Harbormaster completed remote builds in B30985: Diff 50643.Nov 4 2024, 17:14

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_getavaaddr.py ======

------- Stdout: -------
2024-11-04T17:07:33.375000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20241104_170616/abc_p2p_getavaaddr_12
2024-11-04T17:08:35.203000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2024-11-04T17:08:35.203000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 535, in run_test
    self.getavaaddr_interval_test()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 173, in getavaaddr_interval_test
    requester.wait_until(requester.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 582, in wait_until
    wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 300, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2024-11-04T17:08:35.254000Z TestFramework (INFO): Stopping nodes
2024-11-04T17:08:35.406000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20241104_170616/abc_p2p_getavaaddr_12
2024-11-04T17:08:35.406000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20241104_170616/abc_p2p_getavaaddr_12/test_framework.log
2024-11-04T17:08:35.406000Z TestFramework (ERROR): 
2024-11-04T17:08:35.406000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20241104_170616/abc_p2p_getavaaddr_12' to consolidate all logs
2024-11-04T17:08:35.406000Z TestFramework (ERROR): 
2024-11-04T17:08:35.406000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-04T17:08:35.406000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-11-04T17:08:35.406000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_getavaaddr.py

roqqit accepted this revision.Nov 4 2024, 17:20

roqqit added a subscriber: roqqit.

roqqit added inline comments.

src/net_processing.cpp
7153–7154 ↗	(On Diff #50643)	This comment is still useful, right?

This revision is now accepted and ready to land.Nov 4 2024, 17:20

Back to you for the test failure

This revision now requires changes to proceed.Nov 4 2024, 17:21

I will split out the test fix

Rebase on top of D17076 to fix the test

Fabien edited the summary of this revision. (Show Details)Nov 4 2024, 21:15

Fabien added a parent revision: D17076: [avalanche] Fix the getavaaddr functional test.

Harbormaster completed remote builds in B30994: Diff 50654.Nov 4 2024, 21:30

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_getavaaddr.py ======

------- Stdout: -------
2024-11-04T21:22:30.845000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20241104_212053/abc_p2p_getavaaddr_12
2024-11-04T21:23:33.244000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2024-11-04T21:23:33.245000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 545, in run_test
    self.getavaaddr_interval_test()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 183, in getavaaddr_interval_test
    requester.wait_until(requester.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 582, in wait_until
    wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 300, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2024-11-04T21:23:33.296000Z TestFramework (INFO): Stopping nodes
2024-11-04T21:23:33.397000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20241104_212053/abc_p2p_getavaaddr_12
2024-11-04T21:23:33.397000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20241104_212053/abc_p2p_getavaaddr_12/test_framework.log
2024-11-04T21:23:33.397000Z TestFramework (ERROR): 
2024-11-04T21:23:33.398000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20241104_212053/abc_p2p_getavaaddr_12' to consolidate all logs
2024-11-04T21:23:33.398000Z TestFramework (ERROR): 
2024-11-04T21:23:33.398000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-04T21:23:33.398000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-11-04T21:23:33.398000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_getavaaddr.py

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_getavaaddr.py ======

------- Stdout: -------
2024-11-04T21:28:30.407000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20241104_212719/abc_p2p_getavaaddr_12
2024-11-04T21:29:32.597000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
'''
2024-11-04T21:29:32.597000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 147, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 137, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 545, in run_test
    self.getavaaddr_interval_test()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 183, in getavaaddr_interval_test
    requester.wait_until(requester.addr_received)
  File "/work/test/functional/test_framework/p2p.py", line 582, in wait_until
    wait_until_helper(
  File "/work/test/functional/test_framework/util.py", line 300, in wait_until_helper
    raise AssertionError(
AssertionError: Predicate ''''
        def test_function():
            if check_connected:
                assert self.is_connected
            return test_function_in()
''' not true after 60.0 seconds
2024-11-04T21:29:32.652000Z TestFramework (INFO): Stopping nodes
2024-11-04T21:29:32.855000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20241104_212719/abc_p2p_getavaaddr_12
2024-11-04T21:29:32.855000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20241104_212719/abc_p2p_getavaaddr_12/test_framework.log
2024-11-04T21:29:32.855000Z TestFramework (ERROR): 
2024-11-04T21:29:32.855000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20241104_212719/abc_p2p_getavaaddr_12' to consolidate all logs
2024-11-04T21:29:32.855000Z TestFramework (ERROR): 
2024-11-04T21:29:32.855000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-04T21:29:32.855000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-11-04T21:29:32.855000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_getavaaddr.py