Page MenuHomePhabricator
Differential D1811

[depends] Backport various changes to Qt build
ClosedPublic
Actions

Authored by deadalnix on Sep 26 2018, 17:09.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING20ffd57d307d: [depends] Backport various changes to Qt build
rABC20ffd57d307d: [depends] Backport various changes to Qt build
Summary
  • [Depends] Fix Qt build with Xcode 9.2 (PR11995)
  • depends: Fix Qt build with XCode 9.3 (PR12946)
  • depends: Update Qt download url (PR13544)
Test Plan
make -C ../depends build-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
dependsqtupdate
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3383
Build 4847: Bitcoin ABC Buildbot (legacy)
Build 4846: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 26 2018, 17:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2018, 17:09
teamcity added a subscriber: teamcity.Sep 26 2018, 17:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 26 2018, 17:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3383: Diff 5068.Sep 26 2018, 17:27
jasonbcox accepted this revision.Sep 26 2018, 18:49
jasonbcox added a subscriber: jasonbcox.

This change looks relatively benign, but I don't really know the specifics of what it accomplishes. I would prefer review by someone more knowledgeable about building with XCode, but I don't think we have such a person.

This revision is now accepted and ready to land.Sep 26 2018, 18:49
Closed by commit rABC20ffd57d307d: [depends] Backport various changes to Qt build (authored by fanquake <fanquake@gmail.com>, committed by deadalnix). · Explain WhySep 26 2018, 18:53
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
depends/
packages/
8 lines
patches/
qt/
70 lines
34 lines

Diff 5068

View Options

depends/packages/qt.mk

Loading...
View Options

depends/patches/qt/clang-5-darwin.patch

Loading...
View Options

depends/patches/qt/fix-cocoahelpers-macos.patch

Loading...
View Options

depends/patches/qt/qfixed-coretext.patch

Loading...