Paths

Table of Contentst

Differential D17090

[Cashtab] Improve flakiness in orderbook tests
ClosedPublic
Actions

Authored by bytesofman on Wed, Nov 6, 18:09.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa2ed269a3d3c: [Cashtab] Improve flakiness in orderbook tests

Summary

The min amounts are calculated, so can have a race condition here.

Use await screen.findByText for values that are expected to appear after async.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

flakiness-improvement

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31038
Build 61579: Build Diff	cashtab-tests
Build 61578: arc lint + arc unit

Event Timeline

bytesofman created this revision.Wed, Nov 6, 18:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 6, 18:09

Harbormaster completed remote builds in B31038: Diff 50711.Wed, Nov 6, 18:12

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests: <SendXec /> Pass a valid alias and bip21 query string with invalid amount param (too many decimals) to Send To field ======
Error: expect(element).toHaveValue(chicken.xec?amount=500.123)

Expected the element to have value:
  chicken.xec?amount=500.123
Received:
  chicken.xec?amount=500.23
    at Object.toHaveValue (/work/cashtab/src/components/Send/__tests__/SendXec.test.js:815:32)

Each failure log is accessible here:
CashTab Unit Tests: <SendXec /> Pass a valid alias and bip21 query string with invalid amount param (too many decimals) to Send To field

In D17090#387775, @teamcity wrote:
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:
====== CashTab Unit Tests: <SendXec /> Pass a valid alias and bip21 query string with invalid amount param (too many decimals) to Send To field ======
Error: expect(element).toHaveValue(chicken.xec?amount=500.123)

Expected the element to have value:
  chicken.xec?amount=500.123
Received:
  chicken.xec?amount=500.23
    at Object.toHaveValue (/work/cashtab/src/components/Send/__tests__/SendXec.test.js:815:32)
Each failure log is accessible here:
CashTab Unit Tests: <SendXec /> Pass a valid alias and bip21 query string with invalid amount param (too many decimals) to Send To field

haven't seen this before...will keep an eye on it

bytesofman published this revision for review.Wed, Nov 6, 19:03

Fabien accepted this revision.Thu, Nov 7, 08:42

This revision is now accepted and ready to land.Thu, Nov 7, 08:42

Closed by commit rABCa2ed269a3d3c: [Cashtab] Improve flakiness in orderbook tests (authored by bytesofman). · Explain WhyThu, Nov 7, 13:57

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCa2ed269a3d3c: [Cashtab] Improve flakiness in orderbook tests.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Agora/

OrderBook/

__tests__/

index.test.js

4 lines

Diff 50711

View Options

cashtab/src/components/Agora/OrderBook/tests/index.test.js

[Cashtab] Improve flakiness in orderbook testsClosedPublicActions