Page MenuHomePhabricator

[Cashtab] Patch ts bug in button components and propagate type
ClosedPublic

Authored by bytesofman on Nov 8 2024, 13:02.

Details

Summary

Something else discovered in D17074 but not directly related

The disabled prop is optional, we do not require disabled prop on every button.

The name prop is required for CopyIconButton. Propagate this.

Note this was not caught until D17074 because tslinter only finds this in ts files, and Cashtab has not completely converted yet.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
buttons-tsx-patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31073
Build 61647: Build Diffcashtab-tests
Build 61646: arc lint + arc unit