Paths

Table of Contentst

Differential D17115

test: add option to speed up tx relay/mempool sync
ClosedPublic
Actions

Authored by PiRK on Tue, Nov 12, 14:28.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC7fbc409146b0: test: add option to speed up tx relay/mempool sync

Summary

when self.noban_tx_relay=True, the following flag
-whitelist=noban,in,out@127.0.0.1is added to extra_args
to speed up tx relay/mempool sync.

Before (all functional tests):

ALL                                        | ✓ Passed  | 1465 s (accumulated)
Runtime: 163 s

After:

ALL                                        | ✓ Passed  | 1350 s (accumulated)
Runtime: 150 s

This makes test duration shorter and hopefully solves some rare timeouts in interface_rest.py

This concludes backport of core#27114
https://github.com/bitcoin/bitcoin/pull/27114/commits/c985eb854cc86deb747caea5283c17cf51b6a983

Bypasses core#26970 and core#29822

Depends on D17114

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr27114

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31095
Build 61691: Build Diff	build-diff · build-clang-tidy · build-debug · build-clang · build-without-wallet
Build 61690: arc lint + arc unit

Event Timeline

PiRK created this revision.Tue, Nov 12, 14:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Nov 12, 14:28

PiRK requested review of this revision.Tue, Nov 12, 14:28

teamcity edited the summary of this revision. (Show Details)Tue, Nov 12, 14:28

Before

interface_rest.py                          | ✓ Passed  | 21 s

After

interface_rest.py                          | ✓ Passed  | 3 s

You should go through the abc tests also. I use this a lot to speed up proof relay in tests

This revision now requires changes to proceed.Tue, Nov 12, 14:40

Harbormaster completed remote builds in B31090: Diff 50784.Tue, Nov 12, 15:03

add more tests (mostly abc*). Note that the new way of setting the option is persistent accross node restarts. abc_p2p_avalanche_proof_voting is an example that fails if we set this attribute, because it needs to restart without the noban permission in one of the subtests.

PiRK added inline comments.Tue, Nov 12, 15:07

test/functional/mempool_reorg.py
24	in this test it does not hurt to set the flag for both nodes, so do it for a reduction in number of loc

PiRK mentioned this in D17113: Improve test coverage of the getblocktemplate longpoll feature with avalanche.Tue, Nov 12, 15:15

Harbormaster completed remote builds in B31095: Diff 50789.Tue, Nov 12, 15:26

please include the mining_getblocktemplate_longpoll.py from D17113

Fabien requested changes to this revision.Tue, Nov 12, 15:41

Fabien added inline comments.

test/functional/abc_feature_persist_avapeers.py
35	it's about proof here. This comment is just annoying imo, you'd better remove it

This revision now requires changes to proceed.Tue, Nov 12, 15:41

remove comment (x52), include new test from D17113

Fabien accepted this revision.Tue, Nov 12, 16:22

This revision is now accepted and ready to land.Tue, Nov 12, 16:22

Harbormaster completed remote builds in B31096: Diff 50791.Tue, Nov 12, 16:32

Closed by commit rABC7fbc409146b0: test: add option to speed up tx relay/mempool sync (authored by brunoerg <brunoely.gc@gmail.com>, committed by PiRK). · Explain WhyTue, Nov 12, 16:53

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7fbc409146b0: test: add option to speed up tx relay/mempool sync.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-invalid-chains.py

9 lines

abc-magnetic-anomaly-mining.py

4 lines

abc-mempool-coherence-on-activations.py

3 lines

abc-replay-protection.py

3 lines

abc-transaction-ordering.py

3 lines

abc_feature_persist_avapeers.py

3 lines

abc_feature_proof_cleanup.py

4 lines

abc_feature_rtt_activation.py

3 lines

abc_mining_rtt.py

3 lines

abc_mining_stakingrewards.py

3 lines

abc_p2p_avalanche_cooldown.py

3 lines

abc_p2p_avalanche_policy_minerfund.py

3 lines

abc_p2p_avalanche_policy_rtt.py

3 lines

abc_p2p_avalanche_policy_stakingrewards.py

3 lines

abc_p2p_avalanche_remote_proofs.py

3 lines

abc_p2p_avalanche_transaction_voting.py

3 lines

abc_p2p_avalanche_voting.py

4 lines

abc_p2p_compactblocks.py

3 lines

abc_p2p_compactproofs.py

3 lines

abc_p2p_fullblocktest.py

9 lines

abc_p2p_getavaaddr.py

3 lines

abc_p2p_proof_inventory.py

3 lines

abc_rpc_avalancheproof.py

3 lines

abc_rpc_invalidateavalancheproof.py

3 lines

chronik_avalanche.py

3 lines

3 lines

chronik_ws_script.py

3 lines

feature_cltv.py

3 lines

feature_csv_activation.py

3 lines

feature_dersig.py

3 lines

interface_rest.py

2 lines

interface_zmq.py

6 lines

mempool_limit.py

3 lines

mempool_packages.py

6 lines

mempool_reorg.py

9 lines

p2p_1p1c_network.py

12 lines

p2p_feefilter.py

5 lines

9 lines

p2p_invalid_block.py

3 lines

rpc_packages.py

3 lines

rpc_rawtransaction.py

6 lines

setup_scripts/

chronik-client_websocket.py

3 lines

test_framework/

test_framework.py

6 lines

wallet_abandonconflict.py

3 lines

wallet_address_types.py

4 lines

wallet_avoidreuse.py

5 lines

wallet_backup.py

13 lines

wallet_balance.py

2 lines

wallet_basic.py

7 lines

wallet_groups.py

5 lines

3 lines

wallet_import_rescan.py

2 lines

wallet_importdescriptors.py

5 lines

wallet_listreceivedby.py

2 lines

wallet_listsinceblock.py

3 lines

wallet_listtransactions.py

5 lines

11 lines

Diff 50789

test/functional/abc-invalid-chains.py

Loading...

test/functional/abc-magnetic-anomaly-mining.py

Loading...

test/functional/abc-mempool-coherence-on-activations.py

Loading...

test/functional/abc-replay-protection.py

Loading...

test/functional/abc-transaction-ordering.py

Loading...

test/functional/abc_feature_persist_avapeers.py

Loading...

test/functional/abc_feature_proof_cleanup.py

Loading...

test/functional/abc_feature_rtt_activation.py

Loading...

test/functional/abc_mining_rtt.py

Loading...

test/functional/abc_mining_stakingrewards.py

Loading...

test/functional/abc_p2p_avalanche_cooldown.py

Loading...

test/functional/abc_p2p_avalanche_policy_minerfund.py

Loading...

test/functional/abc_p2p_avalanche_policy_rtt.py

Loading...

test/functional/abc_p2p_avalanche_policy_stakingrewards.py

Loading...

test/functional/abc_p2p_avalanche_remote_proofs.py

Loading...

test/functional/abc_p2p_avalanche_transaction_voting.py

Loading...

test/functional/abc_p2p_avalanche_voting.py

Loading...

test/functional/abc_p2p_compactblocks.py

Loading...

test/functional/abc_p2p_compactproofs.py

Loading...

test/functional/abc_p2p_fullblocktest.py

Loading...

test/functional/abc_p2p_getavaaddr.py

Loading...

test/functional/abc_p2p_proof_inventory.py

Loading...

test/functional/abc_rpc_avalancheproof.py

Loading...

test/functional/abc_rpc_invalidateavalancheproof.py

Loading...

test/functional/chronik_avalanche.py

Loading...

test/functional/chronik_ws.py

Loading...

test/functional/chronik_ws_script.py

Loading...

test/functional/feature_cltv.py

Loading...

test/functional/feature_csv_activation.py

Loading...

test/functional/feature_dersig.py

Loading...

test/functional/interface_rest.py

Loading...

test/functional/interface_zmq.py

Loading...

test/functional/mempool_limit.py

Loading...

test/functional/mempool_packages.py

Loading...

test/functional/mempool_reorg.py

Loading...

test/functional/p2p_1p1c_network.py

Loading...

test/functional/p2p_feefilter.py

Loading...

test/functional/p2p_filter.py

Loading...

test/functional/p2p_invalid_block.py

Loading...

test/functional/rpc_packages.py

Loading...

test/functional/rpc_rawtransaction.py

Loading...

test/functional/setup_scripts/chronik-client_websocket.py

Loading...

test/functional/test_framework/test_framework.py

Loading...

test/functional/wallet_abandonconflict.py

Loading...

test/functional/wallet_address_types.py

Loading...

test/functional/wallet_avoidreuse.py

Loading...

test/functional/wallet_backup.py

Loading...

test/functional/wallet_balance.py

Loading...

test/functional/wallet_basic.py

Loading...

test/functional/wallet_groups.py

Loading...

test/functional/wallet_hd.py

Loading...

test/functional/wallet_import_rescan.py

Loading...

test/functional/wallet_importdescriptors.py

Loading...

test/functional/wallet_listreceivedby.py

Loading...

test/functional/wallet_listsinceblock.py

Loading...

test/functional/wallet_listtransactions.py

Loading...

test/functional/wallet_send.py

Loading...