Page MenuHomePhabricator
Differential D17115

test: add option to speed up tx relay/mempool sync
ClosedPublic
Actions

Authored by PiRK on Nov 12 2024, 14:28.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7fbc409146b0: test: add option to speed up tx relay/mempool sync
Summary

when self.noban_tx_relay=True, the following flag
-whitelist=noban,in,out@127.0.0.1is added to extra_args
to speed up tx relay/mempool sync.

Before (all functional tests):

ALL                                        | ✓ Passed  | 1465 s (accumulated)
Runtime: 163 s

After:

ALL                                        | ✓ Passed  | 1350 s (accumulated)
Runtime: 150 s

This makes test duration shorter and hopefully solves some rare timeouts in interface_rest.py

This concludes backport of core#27114
https://github.com/bitcoin/bitcoin/pull/27114/commits/c985eb854cc86deb747caea5283c17cf51b6a983

Bypasses core#26970 and core#29822

Depends on D17114

Test Plan

ninja check-functional

Diff Detail

Event Timeline

PiRK created this revision.Nov 12 2024, 14:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 12 2024, 14:28
PiRK requested review of this revision.Nov 12 2024, 14:28
teamcity edited the summary of this revision. (Show Details)Nov 12 2024, 14:28
PiRK added a comment.Nov 12 2024, 14:30

Before

interface_rest.py                          | ✓ Passed  | 21 s

After

interface_rest.py                          | ✓ Passed  | 3 s
Fabien requested changes to this revision.Nov 12 2024, 14:40
Fabien added a subscriber: Fabien.

You should go through the abc tests also. I use this a lot to speed up proof relay in tests

This revision now requires changes to proceed.Nov 12 2024, 14:40
Harbormaster completed remote builds in B31090: Diff 50784.Nov 12 2024, 15:03
PiRK updated this revision to Diff 50789.Nov 12 2024, 15:05
PiRK edited the summary of this revision. (Show Details)

add more tests (mostly abc*). Note that the new way of setting the option is persistent accross node restarts. abc_p2p_avalanche_proof_voting is an example that fails if we set this attribute, because it needs to restart without the noban permission in one of the subtests.

PiRK added inline comments.Nov 12 2024, 15:07
test/functional/mempool_reorg.py
24 ↗(On Diff #50789)

in this test it does not hurt to set the flag for both nodes, so do it for a reduction in number of loc

PiRK mentioned this in D17113: Improve test coverage of the getblocktemplate longpoll feature with avalanche.Nov 12 2024, 15:15
Harbormaster completed remote builds in B31095: Diff 50789.Nov 12 2024, 15:26
Fabien added a comment.Nov 12 2024, 15:40

please include the mining_getblocktemplate_longpoll.py from D17113

Fabien requested changes to this revision.Nov 12 2024, 15:41
Fabien added inline comments.
test/functional/abc_feature_persist_avapeers.py
35 ↗(On Diff #50789)

it's about proof here. This comment is just annoying imo, you'd better remove it

This revision now requires changes to proceed.Nov 12 2024, 15:41
PiRK updated this revision to Diff 50791.Nov 12 2024, 16:13

remove comment (x52), include new test from D17113

Fabien accepted this revision.Nov 12 2024, 16:22
This revision is now accepted and ready to land.Nov 12 2024, 16:22
Harbormaster completed remote builds in B31096: Diff 50791.Nov 12 2024, 16:32
Closed by commit rABC7fbc409146b0: test: add option to speed up tx relay/mempool sync (authored by brunoerg <brunoely.gc@gmail.com>, committed by PiRK). · Explain WhyNov 12 2024, 16:53
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC7fbc409146b0: test: add option to speed up tx relay/mempool sync.

Revision Contents
Changeset List

PathSize
test/
functional/
8 lines
3 lines
2 lines
2 lines
2 lines
2 lines
3 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
3 lines
2 lines
2 lines
8 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
1 line
5 lines
2 lines
5 lines
8 lines
2 lines
11 lines
4 lines
8 lines
2 lines
2 lines
5 lines
setup_scripts/
2 lines
test_framework/
6 lines
4 lines
3 lines
4 lines
12 lines
3 lines
6 lines
4 lines
4 lines
1 line
4 lines
3 lines
4 lines
4 lines
10 lines

Diff 50791

View Options

test/functional/abc-invalid-chains.py

Loading...
View Options

test/functional/abc-magnetic-anomaly-mining.py

Loading...
View Options

test/functional/abc-mempool-coherence-on-activations.py

Loading...
View Options

test/functional/abc-replay-protection.py

Loading...
View Options

test/functional/abc-transaction-ordering.py

Loading...
View Options

test/functional/abc_feature_persist_avapeers.py

Loading...
View Options

test/functional/abc_feature_proof_cleanup.py

Loading...
View Options

test/functional/abc_feature_rtt_activation.py

Loading...
View Options

test/functional/abc_mining_rtt.py

Loading...
View Options

test/functional/abc_mining_stakingrewards.py

Loading...
View Options

test/functional/abc_p2p_avalanche_cooldown.py

Loading...
View Options

test/functional/abc_p2p_avalanche_policy_minerfund.py

Loading...
View Options

test/functional/abc_p2p_avalanche_policy_rtt.py

Loading...
View Options

test/functional/abc_p2p_avalanche_policy_stakingrewards.py

Loading...
View Options

test/functional/abc_p2p_avalanche_remote_proofs.py

Loading...
View Options

test/functional/abc_p2p_avalanche_transaction_voting.py

Loading...
View Options

test/functional/abc_p2p_avalanche_voting.py

Loading...
View Options

test/functional/abc_p2p_compactblocks.py

Loading...
View Options

test/functional/abc_p2p_compactproofs.py

Loading...
View Options

test/functional/abc_p2p_fullblocktest.py

Loading...
View Options

test/functional/abc_p2p_getavaaddr.py

Loading...
View Options

test/functional/abc_p2p_proof_inventory.py

Loading...
View Options

test/functional/abc_rpc_avalancheproof.py

Loading...
View Options

test/functional/abc_rpc_invalidateavalancheproof.py

Loading...
View Options

test/functional/chronik_avalanche.py

Loading...
View Options

test/functional/chronik_ws.py

Loading...
View Options

test/functional/chronik_ws_script.py

Loading...
View Options

test/functional/feature_cltv.py

Loading...
View Options

test/functional/feature_csv_activation.py

Loading...
View Options

test/functional/feature_dersig.py

Loading...
View Options

test/functional/interface_rest.py

Loading...
View Options

test/functional/interface_zmq.py

Loading...
View Options

test/functional/mempool_limit.py

Loading...
View Options

test/functional/mempool_packages.py

Loading...
View Options

test/functional/mempool_reorg.py

Loading...
View Options

test/functional/mining_getblocktemplate_longpoll.py

Loading...
View Options

test/functional/p2p_1p1c_network.py

Loading...
View Options

test/functional/p2p_feefilter.py

Loading...
View Options

test/functional/p2p_filter.py

Loading...
View Options

test/functional/p2p_invalid_block.py

Loading...
View Options

test/functional/rpc_packages.py

Loading...
View Options

test/functional/rpc_rawtransaction.py

Loading...
View Options

test/functional/setup_scripts/chronik-client_websocket.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/wallet_abandonconflict.py

Loading...
View Options

test/functional/wallet_address_types.py

Loading...
View Options

test/functional/wallet_avoidreuse.py

Loading...
View Options

test/functional/wallet_backup.py

Loading...
View Options

test/functional/wallet_balance.py

Loading...
View Options

test/functional/wallet_basic.py

Loading...
View Options

test/functional/wallet_groups.py

Loading...
View Options

test/functional/wallet_hd.py

Loading...
View Options

test/functional/wallet_import_rescan.py

Loading...
View Options

test/functional/wallet_importdescriptors.py

Loading...
View Options

test/functional/wallet_listreceivedby.py

Loading...
View Options

test/functional/wallet_listsinceblock.py

Loading...
View Options

test/functional/wallet_listtransactions.py

Loading...
View Options

test/functional/wallet_send.py

Loading...