Page MenuHomePhabricator

[ecash-herald] Present daily total volume for agora
ClosedPublic

Authored by bytesofman on Nov 12 2024, 19:48.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC847bb4b29c66: [ecash-herald] Present daily total volume for agora
Summary

Depends on D17118

Calculate and present total agora volume for partial and oneshot txs.

Later will also get this information on a per-token basis. But we want the total summary as well, so do that first.

Test Plan

npm test

image.png (503×470 px, 91 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-patch-apptxs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31103
Build 61707: Build Diffecash-herald-tests
Build 61706: arc lint + arc unit

Event Timeline

bytesofman edited the test plan for this revision. (Show Details)
bytesofman added inline comments.
apps/ecash-herald/src/parse.ts
3148

we need to improve the satsToFormattedValue function to work with the variables in the daily summaries. this should be a separate diff.

This revision is now accepted and ready to land.Nov 12 2024, 23:11