Page MenuHomePhabricator
Differential D17137

fuzz: Add fuzzing harness for Socks5(...)
ClosedPublic
Actions

Authored by PiRK on Thu, Nov 14, 11:31.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5bea016076f0: fuzz: Add fuzzing harness for Socks5(...)
Summary

This is a backport of core#19203, core#21328, core#20812 (for PickValueInArray((const std::array<T, size> &array)) and core#21371

with changes from:

Test Plan

ninja bitcoin-fuzzers

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Thu, Nov 14, 11:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Nov 14, 11:31
PiRK requested review of this revision.Thu, Nov 14, 11:31
teamcity edited the summary of this revision. (Show Details)Thu, Nov 14, 11:31
PiRK added a child revision: D17130: refactor: wrap accept() and extend usage of Sock.Thu, Nov 14, 11:33
PiRK mentioned this in D17131: net: use Sock in CNode.Thu, Nov 14, 11:36
Harbormaster completed remote builds in B31138: Diff 50854.Thu, Nov 14, 11:53
Fabien requested changes to this revision.Thu, Nov 14, 13:17
Fabien added a subscriber: Fabien.

I think the backports are not correct for this diff, none of the netbase changes are from the listed commits afaict

This revision now requires changes to proceed.Thu, Nov 14, 13:17
PiRK edited the summary of this revision. (Show Details)Thu, Nov 14, 13:31

I missed the main one: core#19203
I added it to the summary

PiRK requested review of this revision.Thu, Nov 14, 13:34
Fabien added inline comments.Thu, Nov 14, 13:43
src/test/fuzz/util.h
582 ↗(On Diff #50854)

Is that still used ?

PiRK added inline comments.Thu, Nov 14, 13:55
src/test/fuzz/util.h
582 ↗(On Diff #50854)

It is still used, yes. i2p.cpp has it for example (if (m_control_sock->Get() != INVALID_SOCKET))

It will be removed in core#26312

Fabien accepted this revision.Thu, Nov 14, 14:05
This revision is now accepted and ready to land.Thu, Nov 14, 14:05
Closed by commit rABC5bea016076f0: fuzz: Add fuzzing harness for Socks5(...) (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by PiRK). · Explain WhyMon, Nov 18, 06:42
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC5bea016076f0: fuzz: Add fuzzing harness for Socks5(...).

Revision Contents
Changeset List

PathSize
src/
9 lines
29 lines
test/
fuzz/
1 line
7 lines
50 lines
119 lines

Diff 50913

View Options

src/netbase.h

Loading...
View Options

src/netbase.cpp

Loading...
View Options

src/test/fuzz/CMakeLists.txt

Loading...
View Options

src/test/fuzz/FuzzedDataProvider.h

Loading...
View Options

src/test/fuzz/socks5.cpp

Loading...
View Options

src/test/fuzz/util.h

Loading...