Paths

Table of Contentst

Differential D17157

util: Add ParseHex<std::byte>() helper
ClosedPublic
Actions

Authored by PiRK on Mon, Nov 18, 10:25.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC000b0266e7e8: util: Add ParseHex<std::byte>() helper

Summary

test: Add test for embedded null in hex string

util: Add ParseHex<std::byte>() helper

refactor: Use Span of std::byte in CExtKey::SetSeed

This is a backport of core#23595

with a minor change from core#23413 in key_io_tests (should have been included in D14768 if we got the backports in the right order)

Depends on D17156

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31184
Build 61868: Build Diff	lint-circular-dependencies · build-without-wallet · build-fuzzer · build-diff · build-debug · build-clang-tidy · build-clang
Build 61867: arc lint + arc unit

Event Timeline

PiRK created this revision.Mon, Nov 18, 10:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 18, 10:25

PiRK requested review of this revision.Mon, Nov 18, 10:25

teamcity edited the summary of this revision. (Show Details)Mon, Nov 18, 10:25

PiRK edited the summary of this revision. (Show Details)Mon, Nov 18, 10:28

PiRK added a parent revision: D17156: refactor: Take Span in SetSeed.

PiRK added a child revision: D17158: Handle invalid hex encoding in ParseHex.Mon, Nov 18, 11:10

Harbormaster completed remote builds in B31184: Diff 50929.Mon, Nov 18, 11:21

roqqit accepted this revision.Mon, Nov 18, 17:16

This revision is now accepted and ready to land.Mon, Nov 18, 17:16

Closed by commit rABC000b0266e7e8: util: Add ParseHex<std::byte>() helper (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyMon, Nov 18, 19:57

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC000b0266e7e8: util: Add ParseHex<std::byte>() helper.

Revision Contents
Changeset List

Path

Size

src/

key.h

6 lines

key.cpp

4 lines

test/

bip32_tests.cpp

2 lines

fuzz/

hex.cpp

2 lines

key_io_tests.cpp

6 lines

util_tests.cpp

10 lines

util/

strencodings.h

7 lines

strencodings.cpp

9 lines

Diff 50929

View Options

src/key.h

View Options

src/key.cpp

View Options

src/test/bip32_tests.cpp

View Options

src/test/fuzz/hex.cpp

View Options

src/test/key_io_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/util/strencodings.h

View Options

util: Add ParseHex<std::byte>() helperClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50929

src/key.h

src/key.cpp

src/test/bip32_tests.cpp

src/test/fuzz/hex.cpp

src/test/key_io_tests.cpp

src/test/util_tests.cpp

src/util/strencodings.h

src/util/strencodings.cpp

util: Add ParseHex<std::byte>() helper
ClosedPublic
Actions

Revision Contents
Changeset List