CMakeLists.txt
ClosedPublic
Actions

Authored by tobias_ruck on Thu, Nov 21, 13:36.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCbc5c8fabb06c: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt

Summary

If someone wants to rename the project, they'd also need to change these variables.

Instead, we fix this by using CMAKE_PROJECT_NAME when building the config header.

Test Plan

ninja check && ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake-use-project-name-for-version-config

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31244
Build 61987: Build Diff	build-debug · build-without-wallet · build-clang-tidy · build-clang · build-diff · lint-circular-dependencies
Build 61986: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Thu, Nov 21, 13:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Nov 21, 13:36

tobias_ruck requested review of this revision.Thu, Nov 21, 13:36

we already have CMAKE_PROJECT_NAME, use that instead of making our own

remove unrelated changes

tobias_ruck retitled this revision from [Cmake] Add ROOT_PROJECT_NAME, use in src/config/CMakeLists.txt to [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.Thu, Nov 21, 13:47

tobias_ruck edited the summary of this revision. (Show Details)

@bot guix-linux

teamcity awarded a token.Thu, Nov 21, 13:53

Harbormaster completed remote builds in B31244: Diff 51009.Thu, Nov 21, 13:58

Harbormaster completed remote builds in B31245: Diff 51010.Thu, Nov 21, 14:08

Harbormaster completed remote builds in B31246: Diff 51011.Thu, Nov 21, 14:23

Fabien accepted this revision.Thu, Nov 21, 17:00

This revision is now accepted and ready to land.Thu, Nov 21, 17:00

Closed by commit rABCbc5c8fabb06c: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt (authored by tobias_ruck). · Explain WhyThu, Nov 21, 17:10

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCbc5c8fabb06c: [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.