Page MenuHomePhabricator

[Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt
ClosedPublic

Authored by tobias_ruck on Nov 21 2024, 13:36.

Details

Summary

If someone wants to rename the project, they'd also need to change these variables.

Instead, we fix this by using CMAKE_PROJECT_NAME when building the config header.

Test Plan

ninja check && ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake-use-project-name-for-version-config
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31244
Build 61987: Build Diffbuild-debug · build-without-wallet · build-clang-tidy · build-clang · build-diff · lint-circular-dependencies
Build 61986: arc lint + arc unit

Event Timeline

we already have CMAKE_PROJECT_NAME, use that instead of making our own

tobias_ruck retitled this revision from [Cmake] Add ROOT_PROJECT_NAME, use in src/config/CMakeLists.txt to [Cmake] Use CMAKE_PROJECT_NAME in src/config/CMakeLists.txt.Nov 21 2024, 13:47
tobias_ruck edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Nov 21 2024, 17:00