Page MenuHomePhabricator
Differential D17193

[ecash-lib] Add support for LEGACY sighash
Needs RevisionPublic
Actions

Authored by tobias_ruck on Sat, Nov 23, 18:50.

Details

Reviewers
bytesofman
Fabien
Group Reviewers
Restricted Project
Summary

This is the OG pre-UAHF sighash from Bitcoin, which is invalid on eCash, but still can be used on Bitcoin, Dogecoin and others.

Note: This cannot be tested on eCash as regtest will never run legacy sigchecks. There, IS_LEGACY_MODE must be commited as false.

This is a forwardport of https://github.com/dogecash-io/dogecash/pull/80.

Test Plan
  1. Change IS_LEGACY_MODE to true in txBuilder.test.ts
  2. Download the latest dogecash version from https://download.dogecash.io
  3. Unzip, rename the bin directory in it to src, and dogecoind to bitcoind
  4. Within modules/ecash-lib, run BUILD_DIR=<path/containing/that/src> npm run integration-tests

Diff Detail

Event Timeline

tobias_ruck created this revision.Sat, Nov 23, 18:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Nov 23, 18:50
tobias_ruck requested review of this revision.Sat, Nov 23, 18:50
tobias_ruck edited the summary of this revision. (Show Details)Sat, Nov 23, 18:53
Harbormaster completed remote builds in B31292: Diff 51069.Sat, Nov 23, 18:54
teamcity added a comment.Sat, Nov 23, 18:54
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

FAIL src/components/App/fixtures/__tests__/CashtabTestWrapper.test.js
  ● Test suite failed to run

    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    /work/modules/ecash-lib/dist/ffi/ecash_lib_wasm_browser.js:307
        input = new URL('ecash_lib_wasm_bg_browser.wasm', import.meta.url);
                                                                 ^^^^

    SyntaxError: Cannot use 'import.meta' outside a module

      4 |
      5 | import { __setEcc } from './ecc.js';
    > 6 | import __wbg_init, * as ffi from './ffi/ecash_lib_wasm_browser.js';
        | ^
      7 | import { __setHashes } from './hash.js';
      8 |
      9 | /** Load and initialize the WASM module for Web */

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1505:14)
      at Object.require (../modules/ecash-lib/src/initBrowser.ts:6:1)
      at Object.require (../modules/ecash-lib/src/indexBrowser.ts:6:1)
      at Object.require (../modules/ecash-lib/src/unsignedTx.ts:6:1)
      at Object.require (../modules/ecash-lib/src/txBuilder.ts:19:1)
      at Object.require (../modules/ecash-lib/src/index.ts:13:1)
      at Object.require (../modules/ecash-lib/src/indexNodeJs.ts:5:1)
      at Object.require (src/wallet/index.ts:11:1)
      at Object.require (src/validation/index.ts:6:1)
      at Object.require (src/wallet/useWallet.ts:6:1)
      at Object.require (src/wallet/context.js:7:1)
      at Object.require (src/components/App/fixtures/CashtabTestWrapper.js:9:1)
      at Object.require (src/components/App/fixtures/__tests__/CashtabTestWrapper.test.js:12:1)


Test Suites: 36 failed, 4 passed, 40 total
Tests:       17 passed, 17 total
Snapshots:   0 total
Time:        10.591 s
Ran all test suites.
Build cashtab-tests failed with exit code 1
tobias_ruck edited the test plan for this revision. (Show Details)Sat, Nov 23, 18:54
teamcity added a comment.Sat, Nov 23, 18:56
Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-tests) failed.

Failed tests logs:

====== Ecash Lib: UnsignedTxInput.sigHashPreimage failure ======
AssertionError: expected [Function] to throw an error
    at Context.<anonymous> (src/unsignedTx.test.ts:444:14)
    at process.processImmediate (node:internal/timers:483:21)

      + expected - actual:  failed to generate Mocha diff

Each failure log is accessible here:
Ecash Lib: UnsignedTxInput.sigHashPreimage failure

tobias_ruck updated this revision to Diff 51070.Sat, Nov 23, 19:53

fix tests

Harbormaster completed remote builds in B31293: Diff 51070.Sat, Nov 23, 19:56
teamcity added a comment.Sat, Nov 23, 19:57
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

FAIL src/helpers/__tests__/index.test.js
  ● Test suite failed to run

    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    /work/modules/ecash-lib/dist/ffi/ecash_lib_wasm_browser.js:307
        input = new URL('ecash_lib_wasm_bg_browser.wasm', import.meta.url);
                                                                 ^^^^

    SyntaxError: Cannot use 'import.meta' outside a module

      4 |
      5 | import { __setEcc } from './ecc.js';
    > 6 | import __wbg_init, * as ffi from './ffi/ecash_lib_wasm_browser.js';
        | ^
      7 | import { __setHashes } from './hash.js';
      8 |
      9 | /** Load and initialize the WASM module for Web */

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1505:14)
      at Object.require (../modules/ecash-lib/src/initBrowser.ts:6:1)
      at Object.require (../modules/ecash-lib/src/indexBrowser.ts:6:1)
      at Object.require (../modules/ecash-lib/src/unsignedTx.ts:6:1)
      at Object.require (../modules/ecash-lib/src/txBuilder.ts:19:1)
      at Object.require (../modules/ecash-lib/src/index.ts:13:1)
      at Object.require (../modules/ecash-lib/src/indexNodeJs.ts:5:1)
      at Object.require (src/wallet/index.ts:11:1)
      at Object.require (src/chronik/index.ts:9:1)
      at Object.require (src/components/App/fixtures/mocks.ts:14:1)
      at Object.require (src/helpers/fixtures/vectors.js:16:1)
      at Object.require (src/helpers/__tests__/index.test.js:15:1)


Test Suites: 36 failed, 4 passed, 40 total
Tests:       17 passed, 17 total
Snapshots:   0 total
Time:        11.184 s
Ran all test suites.
Build cashtab-tests failed with exit code 1
Fabien requested changes to this revision.Mon, Nov 25, 07:41
Fabien added a subscriber: Fabien.

clearing my queue

This revision now requires changes to proceed.Mon, Nov 25, 07:41
tobias_ruck updated this revision to Diff 51106.Tue, Nov 26, 13:42

rebase onto master

tobias_ruck updated this revision to Diff 51107.Tue, Nov 26, 13:52

bump ecash-lib version to 1.1.0

Harbormaster completed remote builds in B31321: Diff 51106.Tue, Nov 26, 13:55
teamcity added a comment.Tue, Nov 26, 13:55
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

FAIL src/components/App/fixtures/__tests__/CashtabTestWrapper.test.js
  ● Test suite failed to run

    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    /work/modules/ecash-lib/dist/ffi/ecash_lib_wasm_browser.js:307
        input = new URL('ecash_lib_wasm_bg_browser.wasm', import.meta.url);
                                                                 ^^^^

    SyntaxError: Cannot use 'import.meta' outside a module

      4 |
      5 | import { __setEcc } from './ecc.js';
    > 6 | import __wbg_init, * as ffi from './ffi/ecash_lib_wasm_browser.js';
        | ^
      7 | import { __setHashes } from './hash.js';
      8 |
      9 | /** Load and initialize the WASM module for Web */

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1505:14)
      at Object.require (../modules/ecash-lib/src/initBrowser.ts:6:1)
      at Object.require (../modules/ecash-lib/src/indexBrowser.ts:6:1)
      at Object.require (../modules/ecash-lib/src/unsignedTx.ts:6:1)
      at Object.require (../modules/ecash-lib/src/txBuilder.ts:19:1)
      at Object.require (../modules/ecash-lib/src/index.ts:13:1)
      at Object.require (../modules/ecash-lib/src/indexNodeJs.ts:5:1)
      at Object.require (src/wallet/index.ts:11:1)
      at Object.require (src/validation/index.ts:6:1)
      at Object.require (src/wallet/useWallet.ts:6:1)
      at Object.require (src/wallet/context.js:7:1)
      at Object.require (src/components/App/fixtures/CashtabTestWrapper.js:9:1)
      at Object.require (src/components/App/fixtures/__tests__/CashtabTestWrapper.test.js:12:1)


Test Suites: 36 failed, 4 passed, 40 total
Tests:       17 passed, 17 total
Snapshots:   0 total
Time:        10.705 s
Ran all test suites.
Build cashtab-tests failed with exit code 1
Harbormaster completed remote builds in B31322: Diff 51107.Tue, Nov 26, 14:07
teamcity added a comment.Tue, Nov 26, 14:07
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

FAIL src/components/OnBoarding/__tests__/index.test.js
  ● Test suite failed to run

    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    /work/modules/ecash-lib/dist/ffi/ecash_lib_wasm_browser.js:307
        input = new URL('ecash_lib_wasm_bg_browser.wasm', import.meta.url);
                                                                 ^^^^

    SyntaxError: Cannot use 'import.meta' outside a module

      4 |
      5 | import { __setEcc } from './ecc.js';
    > 6 | import __wbg_init, * as ffi from './ffi/ecash_lib_wasm_browser.js';
        | ^
      7 | import { __setHashes } from './hash.js';
      8 |
      9 | /** Load and initialize the WASM module for Web */

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1505:14)
      at Object.require (../modules/ecash-lib/src/initBrowser.ts:6:1)
      at Object.require (../modules/ecash-lib/src/indexBrowser.ts:6:1)
      at Object.require (../modules/ecash-lib/src/unsignedTx.ts:6:1)
      at Object.require (../modules/ecash-lib/src/txBuilder.ts:19:1)
      at Object.require (../modules/ecash-lib/src/index.ts:13:1)
      at Object.require (../modules/ecash-lib/src/indexNodeJs.ts:5:1)
      at Object.require (src/wallet/index.ts:11:1)
      at Object.require (src/validation/index.ts:6:1)
      at Object.require (src/wallet/useWallet.ts:6:1)
      at Object.require (src/wallet/context.js:7:1)
      at Object.require (src/components/App/fixtures/CashtabTestWrapper.js:9:1)
      at Object.require (src/components/OnBoarding/__tests__/index.test.js:17:1)


Test Suites: 36 failed, 4 passed, 40 total
Tests:       17 passed, 17 total
Snapshots:   0 total
Time:        10.62 s
Ran all test suites.
Build cashtab-tests failed with exit code 1
teamcity added a comment.Tue, Nov 26, 14:09
Build Bitcoin ABC Diffs / Diff Testing (ecash-herald-tests) failed.

Tail of the build log:

    at /usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4
    at require.extensions.<computed> (/work/apps/ecash-herald/node_modules/ts-node/src/index.ts:1621:12)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/work/apps/ecash-herald/test/chronikWsHandler.test.ts:12:1)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module.m._compile (/work/apps/ecash-herald/node_modules/ts-node/src/index.ts:1618:23)
    at module.exports (/usr/lib/node_modules/nyc/node_modules/default-require-extensions/js.js:7:9)
    at /usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4
    at require.extensions.<computed> (/work/apps/ecash-herald/node_modules/ts-node/src/index.ts:1621:12)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.exports.requireOrImport (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:53:16)
    at async Object.exports.loadFilesAsync (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:100:20)
    at async singleRun (/work/apps/ecash-herald/node_modules/mocha/lib/cli/run-helpers.js:125:3)
    at async Object.exports.handler (/work/apps/ecash-herald/node_modules/mocha/lib/cli/run.js:370:5)
------------------------|---------|----------|---------|---------|----------------------------------
File                    | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                
------------------------|---------|----------|---------|---------|----------------------------------
All files               |    6.41 |     0.14 |       0 |    5.35 |                                  
 ecash-herald           |     100 |      100 |     100 |     100 |                                  
  config.ts             |     100 |      100 |     100 |     100 |                                  
  secrets.ts            |     100 |      100 |     100 |     100 |                                  
 ecash-herald/constants |     100 |      100 |     100 |     100 |                                  
  addresses.ts          |     100 |      100 |     100 |     100 |                                  
  lokad.ts              |     100 |      100 |     100 |     100 |                                  
  miners.ts             |     100 |      100 |     100 |     100 |                                  
  op_return.ts          |     100 |      100 |     100 |     100 |                                  
  senders.ts            |     100 |      100 |     100 |     100 |                                  
  tokens.ts             |     100 |      100 |     100 |     100 |                                  
 ecash-herald/scripts   |      80 |       50 |     100 |      80 |                                  
  prepSecrets.ts        |      80 |       50 |     100 |      80 | 15                               
 ecash-herald/src       |    4.53 |        0 |       0 |    3.35 |                                  
  chronik.ts            |   11.82 |        0 |       0 |    7.95 | 23-64,82-141,155-182,198-265     
  chronikWsHandler.ts   |    4.76 |        0 |       0 |    5.26 | 11-86                            
  events.ts             |    6.32 |        0 |       0 |    6.66 | 18-370                           
  parse.ts              |    1.14 |        0 |       0 |    1.17 | 33-3904                          
  telegram.ts           |   16.66 |        0 |       0 |   11.62 | 23-29,44-82,108-154              
  utils.ts              |   16.34 |        0 |       0 |   10.58 | ...8-398,408-430,450-489,499-513 
------------------------|---------|----------|---------|---------|----------------------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='104']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='1622']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='1']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='690']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='0']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='87']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='83']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='1551']
##teamcity[blockClosed name='Code Coverage Summary']
mv: cannot stat 'test_results/ecash-herald-junit.xml': No such file or directory
Build ecash-herald-tests failed with exit code 1
teamcity added a comment.Tue, Nov 26, 14:09
Build Bitcoin ABC Diffs / Diff Testing (token-server-tests) failed.

Tail of the build log:

    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at /usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4
    at require.extensions.<computed> (/work/apps/token-server/node_modules/ts-node/src/index.ts:1608:43)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/work/apps/token-server/test/vectors.ts:21:1)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module.m._compile (/work/apps/token-server/node_modules/ts-node/src/index.ts:1618:23)
    at module.exports (/usr/lib/node_modules/nyc/node_modules/default-require-extensions/js.js:7:9)
    at /usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4
    at require.extensions.<computed> (/work/apps/token-server/node_modules/ts-node/src/index.ts:1621:12)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/work/apps/token-server/src/chronik/clientHandler.test.ts:8:1)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module.m._compile (/work/apps/token-server/node_modules/ts-node/src/index.ts:1618:23)
    at module.exports (/usr/lib/node_modules/nyc/node_modules/default-require-extensions/js.js:7:9)
    at /usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4
    at require.extensions.<computed> (/work/apps/token-server/node_modules/ts-node/src/index.ts:1621:12)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.exports.requireOrImport (/work/apps/token-server/node_modules/mocha/lib/nodejs/esm-utils.js:53:16)
    at async Object.exports.loadFilesAsync (/work/apps/token-server/node_modules/mocha/lib/nodejs/esm-utils.js:100:20)
    at async singleRun (/work/apps/token-server/node_modules/mocha/lib/cli/run-helpers.js:125:3)
    at async Object.exports.handler (/work/apps/token-server/node_modules/mocha/lib/cli/run.js:370:5)
-------------------|---------|----------|---------|---------|-------------------
File               | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
-------------------|---------|----------|---------|---------|-------------------
All files          |   20.45 |     5.88 |       0 |   20.93 |                   
 scripts           |      60 |       50 |     100 |      60 |                   
  prepSecrets.ts   |      60 |       50 |     100 |      60 | 17-18             
 src/chronik       |   15.38 |        0 |       0 |   15.78 |                   
  clientHandler.ts |   11.76 |        0 |       0 |    12.5 | 27-85             
  parse.ts         |   18.18 |        0 |       0 |   18.18 | 26-32,47-69,78-93 
-------------------|---------|----------|---------|---------|-------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='9']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='44']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='1']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='17']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='0']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='5']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='9']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='43']
##teamcity[blockClosed name='Code Coverage Summary']
mv: cannot stat 'test_results/token-server-junit.xml': No such file or directory
Build token-server-tests failed with exit code 1
tobias_ruck updated this revision to Diff 51110.Tue, Nov 26, 15:28

fix imports (don't use indexBrowser...)

Harbormaster completed remote builds in B31323: Diff 51110.Tue, Nov 26, 15:48
bytesofman requested changes to this revision.Tue, Nov 26, 17:09

since CI tests build all dependencies before they run, it's not necessary to version bump the install in cashtab, token-server, ecash-herald, faucet, or ecash-agora -- they use relative installs and will build this version.

Arguably we "should" include these version bumps, since it would rebuild these apps with this latest version of ecash-lib. But for the purposes of this diff, implementing and showing that it does not break them is enough.

Upgrading Cashtab to use this no-change diff is a separate change, no need to do it here. imo these changes are artifacts of working through the CI issues -- they can be backed out.

This revision now requires changes to proceed.Tue, Nov 26, 17:09
tobias_ruck updated this revision to Diff 51112.Tue, Nov 26, 17:46

remove package-lock.json

Harbormaster completed remote builds in B31325: Diff 51112.Tue, Nov 26, 18:03
bytesofman requested changes to this revision.Tue, Nov 26, 18:57
bytesofman added inline comments.
modules/ecash-lib/src/txBuilder.ts
227–231 ↗(On Diff #51112)

because we return in the if, the else isn't doing anything

modules/ecash-lib/tests/txBuilder.test.ts
211 ↗(On Diff #51112)

is this try...catch from debugging? Is there a good reason to keep it here?

test/functional/setup_scripts/ecash-lib_base.py
18 ↗(On Diff #51112)

what's this new flag for?

This revision now requires changes to proceed.Tue, Nov 26, 18:57
tobias_ruck updated this revision to Diff 51128.Wed, Nov 27, 10:28

address review

Harbormaster completed remote builds in B31338: Diff 51128.Wed, Nov 27, 11:01
Fabien resigned from this revision.Wed, Nov 27, 13:07
bytesofman requested changes to this revision.Wed, Nov 27, 13:41
bytesofman added inline comments.
modules/ecash-lib/package.json
3

want to do minor version bumps with

npm version minor

run from modules/ecash-lib

This command will update it everywhere -- in this case, this line of package.json, and also in two places in package-lock.json

If we update without using this command, we get weird situations in future diffs where package-lock.json seems to be skipping versions.

... as a heads up, I don't know if the command is smart enough to get it right if the version has been manually updated in 1 of the 3 spots.

modules/ecash-lib/src/unsignedTx.ts
90

imo british spellings are traitorous to our economic mission but no blocker

modules/ecash-lib/tests/txBuilder.test.ts
66–67

Please expand this comment

imo including the whole test plan of this diff here would appropriate. This is a sui generis thing in the monorepo. Including some backstory is appropriate.

test/functional/setup_scripts/ecash-lib_legacy.py
5

expand comment here in line with the test file that is (never?) expected to use this

This revision now requires changes to proceed.Wed, Nov 27, 13:41

Revision Contents
Changeset List

PathSize
modules/
ecash-lib/
2 lines
src/
29 lines
352 lines
134 lines
tests/
183 lines
test/
functional/
setup_scripts/
35 lines

Diff 51128

View Options

modules/ecash-lib/package.json

Loading...
View Options

modules/ecash-lib/src/txBuilder.ts

Loading...
View Options

modules/ecash-lib/src/unsignedTx.test.ts

Loading...
View Options

modules/ecash-lib/src/unsignedTx.ts

Loading...
View Options

modules/ecash-lib/tests/txBuilder.test.ts

Loading...
View Options

test/functional/setup_scripts/ecash-lib_legacy.py

Loading...