Differential D17261

build: LLD based macOS toolchain
ClosedPublic
Actions

Authored by Fabien on Nov 30 2024, 11:09.

Tags

None

Subscribers

None

Tokens

"Haypence" token, awarded by teamcity.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCa693a7f85462: build: LLD based macOS toolchain

Summary

This switches us to using a LLD based toolchain for macOS builds.
Benefits

 - Less complicated macOS toolchain.
 - No longer beholden to Apple releasing it's source for cctools, ld64 & libtapi.
 - No more reliance on third parties to modify those sources for us. i.e apple-libtapi, cctools-port (cctools + ld64).

Backport of core#21778.

Note this needs some adaptation or our cmake build, as well as some update in build.sh to work around a cmake bug with llvm-strip.
The Cross build for OSX will be broken on CI (because it lacks the proper clang version). I paused the build for now and will unbreak in a follow-up.

Test Plan

Run the guix osx build.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR21778

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31432
Build 62362: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 62361: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 30 2024, 11:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2024, 11:09

Fabien requested review of this revision.Nov 30 2024, 11:09

teamcity edited the summary of this revision. (Show Details)Nov 30 2024, 11:09

Fabien added inline comments.Nov 30 2024, 11:11

depends/packages/openssl.mk
51	openssl ignores LDFLAGS... So this is the correct way to do it unfortunately

@bot guix-osx

teamcity awarded a token.Nov 30 2024, 11:12

Harbormaster completed remote builds in B31432: Diff 51273.Nov 30 2024, 11:55

PiRK accepted this revision.Nov 30 2024, 13:15

This revision is now accepted and ready to land.Nov 30 2024, 13:15

Closed by commit rABCa693a7f85462: build: LLD based macOS toolchain (authored by Fabien). · Explain WhyNov 30 2024, 19:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa693a7f85462: build: LLD based macOS toolchain.

Revision Contents
Changeset List

Path

Size

cmake/

platforms/

13 lines

contrib/

devtools/

symbol-check.py

2 lines

test-security-check.py

41 lines

guix/

libexec/

30 lines

3 lines

macdeploy/

17 lines

depends/

1 line

builders/

1 line

4 lines

1 line

hosts/

43 lines

packages/

native_cctools.mk

native_libtapi.mk

9 lines

1 line

1 line

4 lines

patches/

native_libtapi/

disable_zlib.patch

qt/

1 line

no_warnings_for_symbols.patch

11 lines

src/

qt/

2 lines

Diff 51273

cmake/platforms/OSX.cmake

Loading...

contrib/devtools/symbol-check.py

Loading...

contrib/devtools/test-security-check.py

Loading...

contrib/guix/libexec/build.sh

Loading...

contrib/guix/manifest.scm

Loading...

contrib/macdeploy/README.md

Loading...

depends/Makefile

Loading...

depends/builders/darwin.mk

Loading...

depends/funcs.mk

Loading...

depends/gen_id

Loading...

depends/hosts/darwin.mk

Loading...

depends/packages/native_cctools.mk

Loading...

depends/packages/native_libtapi.mk

Loading...

depends/packages/native_llvm.mk

Loading...

depends/packages/openssl.mk

Loading...

depends/packages/packages.mk

Loading...

depends/packages/qt.mk

Loading...

depends/patches/native_libtapi/disable_zlib.patch

Loading...

depends/patches/qt/mac-qmake.conf

Loading...

depends/patches/qt/no_warnings_for_symbols.patch

Loading...

src/qt/CMakeLists.txt

Loading...