Page MenuHomePhabricator

[CHRONIK][WEB][MODULES] Updated thiserror from 1.0 -> 2.0.3 in Cargo.toml
Needs ReviewPublic

Authored by hazzarust on Sat, Nov 30, 20:45.

Details

Reviewers
tobias_ruck
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

With the new thiserror version (2.0.3), we can no longer rely on unnamed placeholders {}; we must either pass named arguments (e.g., {named_argument}) or use explicit positional placeholders ({0}, {1}) for clarity and correctness.

old code:

`#[error(
     "Bad usage of merge: Unknown prefix {0:02x}, expected C or T: {}",
     hex::encode(.1),
 )]
 UnknownOperandPrefix(u8, Vec<u8>),`

The (.1) in hex::encode(.1) is an ambiguous reference because thiserror is expecting named arguments
and doesn't understand that .1 refers to the second element of the tuple. Therefore, I have named the arguments, so that
its clear to the macro what each argument corresponds to.

new code:

`#[error(
    "Bad usage of merge: Unknown prefix {prefix:02x},
    expected C or T: {encoded}",
    prefix = .0,
    encoded = hex::encode(.1),
)]
UnknownOperandPrefix(u8, Vec<u8>), `

Here, we have made it explicit what .1 refers to, by passing it into a variable and passing it in as an argument into the placeholders.

Test Plan

ninja check-functional

Diff Detail

Event Timeline

Owners added a reviewer: Restricted Owners Package.Sat, Nov 30, 20:45

updated formatting to satisfy lint

Updated thiserror dependency wherever it was used within bitcoin-abc

hazzarust retitled this revision from [CHRONIK] Updated thiserror 2.0.3 in Cargo.toml to [CHRONIK][WEB][MODULES] Updated thiserror from 1.0 -> 2.0.3 in Cargo.toml.Sat, Nov 30, 22:06
hazzarust edited the summary of this revision. (Show Details)

Tail of the build log:

    next(setup_steps)
  File "/work/test/functional/setup_scripts/chronik-client_plugin_groups.py", line 98, in run_test
    assert_equal(
  File "/work/test/functional/setup_scripts/../test_framework/util.py", line 60, in assert_equal
    raise AssertionError(
AssertionError: not(400: Requested page size 51 is too big,
        maximum is 50 == 400: Requested page size 51 is too big, maximum is 50)
2024-11-30T22:14:37.658000Z TestFramework (INFO): Stopping nodes
2024-11-30T22:14:37.811000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/chronik-client-integration-tests/test/tmp/test_runner_₿₵_🏃_20241130_221436/setup_scripts/chronik-client_plugin_groups_0
2024-11-30T22:14:37.811000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/chronik-client-integration-tests/test/tmp/test_runner_₿₵_🏃_20241130_221436/setup_scripts/chronik-client_plugin_groups_0/test_framework.log
2024-11-30T22:14:37.811000Z TestFramework (ERROR): 
2024-11-30T22:14:37.812000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/chronik-client-integration-tests/test/tmp/test_runner_₿₵_🏃_20241130_221436/setup_scripts/chronik-client_plugin_groups_0' to consolidate all logs
2024-11-30T22:14:37.812000Z TestFramework (ERROR): 
2024-11-30T22:14:37.813000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-30T22:14:37.813000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-11-30T22:14:37.813000Z TestFramework (ERROR): 
Running Unit Tests for Test Framework Modules
setup_scripts/chronik-client_plugin_groups.py started
setup_scripts/chronik-client_plugin_groups.py failed, Duration: 2 s

stdout:

stderr:


TEST                                          | STATUS    | DURATION

setup_scripts/chronik-client_plugin_groups.py | ✖ Failed  | 2 s

ALL                                           | ✖ Failed  | 2 s (accumulated) 
Runtime: 2 s

Test runner for chronik-client_plugin_groups completed with code 1
----------------------|---------|----------|---------|---------|------------------------------------
File                  | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                  
----------------------|---------|----------|---------|---------|------------------------------------
All files             |   25.59 |     7.72 |   22.61 |   25.49 |                                    
 chronik-client       |     100 |      100 |     100 |     100 |                                    
  index.ts            |     100 |      100 |     100 |     100 |                                    
 chronik-client/proto |   19.34 |     5.74 |   13.36 |   19.52 |                                    
  chronik.ts          |   19.34 |     5.74 |   13.36 |   19.52 | ...5,6401-6404,6410-6452,6487-6496 
 chronik-client/src   |   54.94 |    31.84 |   53.03 |   53.93 |                                    
  ChronikClient.ts    |   44.16 |    28.57 |   47.95 |   44.16 | ...5,1336-1344,1352-1417,1425-1430 
  failoverProxy.ts    |   79.43 |    56.66 |   69.23 |   78.84 | ...282-285,288,297,304,308,313,317 
  hex.ts              |   89.47 |       50 |      75 |   87.87 | 58,66-68                           
  validation.ts       |   53.65 |    13.33 |      50 |   48.64 | 17,21,33,38-49,62-63,73-88         
----------------------|---------|----------|---------|---------|------------------------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='800']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='3126']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='204']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='2640']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='128']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='566']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='788']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='3091']
##teamcity[blockClosed name='Code Coverage Summary']
mv: cannot stat 'test_results/chronik-client-integration-tests-junit.xml': No such file or directory
Build chronik-client-integration-tests failed with exit code 1

Failed tests logs:

====== Bitcoin ABC functional tests: chronik_block_header.py ======

------- Stdout: -------
2024-11-30T22:14:47.616000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_block_header_176
2024-11-30T22:14:50.323000Z TestFramework (INFO): Test the /header endpoint before mining any block
2024-11-30T22:14:50.325000Z TestFramework (INFO): Test the /headers endpoint before mining any block
2024-11-30T22:14:50.325000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 148, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 138, in _run_test_internal
    self.run_test()
  File "/work/test/functional/chronik_block_header.py", line 88, in run_test
    assert_equal(
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    raise AssertionError(
AssertionError: not(400: Blocks page size too large,
        may not be above 500 but got 501 == 400: Blocks page size too large, may not be above 500 but got 501)
2024-11-30T22:14:50.377000Z TestFramework (INFO): Stopping nodes
2024-11-30T22:14:50.781000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_block_header_176
2024-11-30T22:14:50.782000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_block_header_176/test_framework.log
2024-11-30T22:14:50.782000Z TestFramework (ERROR): 
2024-11-30T22:14:50.782000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_block_header_176' to consolidate all logs
2024-11-30T22:14:50.783000Z TestFramework (ERROR): 
2024-11-30T22:14:50.783000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-30T22:14:50.783000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-11-30T22:14:50.783000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: chronik_block_txs.py ======

------- Stdout: -------
2024-11-30T22:14:30.484000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_block_txs_153
2024-11-30T22:14:33.335000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 148, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 138, in _run_test_internal
    self.run_test()
  File "/work/test/functional/chronik_block_txs.py", line 61, in run_test
    assert_equal(
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    raise AssertionError(
AssertionError: not(400: Requested block tx page size 201 is too big,
        maximum is 200 == 400: Requested block tx page size 201 is too big, maximum is 200)
2024-11-30T22:14:33.387000Z TestFramework (INFO): Stopping nodes
2024-11-30T22:14:33.789000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_block_txs_153
2024-11-30T22:14:33.790000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_block_txs_153/test_framework.log
2024-11-30T22:14:33.790000Z TestFramework (ERROR): 
2024-11-30T22:14:33.790000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_block_txs_153' to consolidate all logs
2024-11-30T22:14:33.790000Z TestFramework (ERROR): 
2024-11-30T22:14:33.791000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-30T22:14:33.791000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-11-30T22:14:33.791000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: chronik_blocks.py ======

------- Stdout: -------
2024-11-30T22:14:48.238000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_blocks_178
2024-11-30T22:14:50.895000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 148, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 138, in _run_test_internal
    self.run_test()
  File "/work/test/functional/chronik_blocks.py", line 38, in run_test
    assert_equal(
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    raise AssertionError(
AssertionError: not(400: Blocks page size too large,
        may not be above 500 but got 501 == 400: Blocks page size too large, may not be above 500 but got 501)
2024-11-30T22:14:50.946000Z TestFramework (INFO): Stopping nodes
2024-11-30T22:14:51.247000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_blocks_178
2024-11-30T22:14:51.248000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_blocks_178/test_framework.log
2024-11-30T22:14:51.248000Z TestFramework (ERROR): 
2024-11-30T22:14:51.248000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_blocks_178' to consolidate all logs
2024-11-30T22:14:51.248000Z TestFramework (ERROR): 
2024-11-30T22:14:51.248000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-30T22:14:51.248000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-11-30T22:14:51.248000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: chronik_script_confirmed_txs.py ======

------- Stdout: -------
2024-11-30T22:13:19.170000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_script_confirmed_txs_95
2024-11-30T22:13:21.926000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 148, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 138, in _run_test_internal
    self.run_test()
  File "/work/test/functional/chronik_script_confirmed_txs.py", line 76, in run_test
    assert_equal(
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    raise AssertionError(
AssertionError: not(400: Requested page size 201 is too big,
        maximum is 200 == 400: Requested page size 201 is too big, maximum is 200)
2024-11-30T22:13:21.977000Z TestFramework (INFO): Stopping nodes
2024-11-30T22:13:22.329000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_script_confirmed_txs_95
2024-11-30T22:13:22.329000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_script_confirmed_txs_95/test_framework.log
2024-11-30T22:13:22.329000Z TestFramework (ERROR): 
2024-11-30T22:13:22.329000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_script_confirmed_txs_95' to consolidate all logs
2024-11-30T22:13:22.329000Z TestFramework (ERROR): 
2024-11-30T22:13:22.329000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-30T22:13:22.329000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-11-30T22:13:22.329000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: chronik_script_history.py ======

------- Stdout: -------
2024-11-30T22:14:01.617000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_script_history_126
2024-11-30T22:14:04.756000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 148, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 138, in _run_test_internal
    self.run_test()
  File "/work/test/functional/chronik_script_history.py", line 81, in run_test
    assert_equal(
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    raise AssertionError(
AssertionError: not(400: Requested page size 201 is too big,
        maximum is 200 == 400: Requested page size 201 is too big, maximum is 200)
2024-11-30T22:14:04.811000Z TestFramework (INFO): Stopping nodes
2024-11-30T22:14:05.166000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_script_history_126
2024-11-30T22:14:05.166000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_script_history_126/test_framework.log
2024-11-30T22:14:05.166000Z TestFramework (ERROR): 
2024-11-30T22:14:05.166000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20241130_220746/chronik_script_history_126' to consolidate all logs
2024-11-30T22:14:05.167000Z TestFramework (ERROR): 
2024-11-30T22:14:05.167000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-30T22:14:05.167000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-11-30T22:14:05.167000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: chronik_block_header.py
Bitcoin ABC functional tests: chronik_block_txs.py
Bitcoin ABC functional tests: chronik_blocks.py
Bitcoin ABC functional tests: chronik_script_confirmed_txs.py
Bitcoin ABC functional tests: chronik_script_history.py

Failed tests logs:

====== Bitcoin ABC functional tests: chronik_block_header.py ======

------- Stdout: -------
2024-11-30T22:17:04.054000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_block_header_176
2024-11-30T22:17:06.709000Z TestFramework (INFO): Test the /header endpoint before mining any block
2024-11-30T22:17:06.712000Z TestFramework (INFO): Test the /headers endpoint before mining any block
2024-11-30T22:17:06.713000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 148, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 138, in _run_test_internal
    self.run_test()
  File "/work/test/functional/chronik_block_header.py", line 88, in run_test
    assert_equal(
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    raise AssertionError(
AssertionError: not(400: Blocks page size too large,
        may not be above 500 but got 501 == 400: Blocks page size too large, may not be above 500 but got 501)
2024-11-30T22:17:06.764000Z TestFramework (INFO): Stopping nodes
2024-11-30T22:17:07.118000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_block_header_176
2024-11-30T22:17:07.118000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_block_header_176/test_framework.log
2024-11-30T22:17:07.118000Z TestFramework (ERROR): 
2024-11-30T22:17:07.119000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_block_header_176' to consolidate all logs
2024-11-30T22:17:07.119000Z TestFramework (ERROR): 
2024-11-30T22:17:07.119000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-30T22:17:07.119000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-11-30T22:17:07.119000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: chronik_block_txs.py ======

------- Stdout: -------
2024-11-30T22:16:46.596000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_block_txs_153
2024-11-30T22:16:49.409000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 148, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 138, in _run_test_internal
    self.run_test()
  File "/work/test/functional/chronik_block_txs.py", line 61, in run_test
    assert_equal(
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    raise AssertionError(
AssertionError: not(400: Requested block tx page size 201 is too big,
        maximum is 200 == 400: Requested block tx page size 201 is too big, maximum is 200)
2024-11-30T22:16:49.461000Z TestFramework (INFO): Stopping nodes
2024-11-30T22:16:49.865000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_block_txs_153
2024-11-30T22:16:49.866000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_block_txs_153/test_framework.log
2024-11-30T22:16:49.866000Z TestFramework (ERROR): 
2024-11-30T22:16:49.866000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_block_txs_153' to consolidate all logs
2024-11-30T22:16:49.866000Z TestFramework (ERROR): 
2024-11-30T22:16:49.867000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-30T22:16:49.867000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-11-30T22:16:49.867000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: chronik_blocks.py ======

------- Stdout: -------
2024-11-30T22:17:04.238000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_blocks_178
2024-11-30T22:17:06.868000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 148, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 138, in _run_test_internal
    self.run_test()
  File "/work/test/functional/chronik_blocks.py", line 38, in run_test
    assert_equal(
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    raise AssertionError(
AssertionError: not(400: Blocks page size too large,
        may not be above 500 but got 501 == 400: Blocks page size too large, may not be above 500 but got 501)
2024-11-30T22:17:06.919000Z TestFramework (INFO): Stopping nodes
2024-11-30T22:17:07.221000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_blocks_178
2024-11-30T22:17:07.221000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_blocks_178/test_framework.log
2024-11-30T22:17:07.221000Z TestFramework (ERROR): 
2024-11-30T22:17:07.221000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_blocks_178' to consolidate all logs
2024-11-30T22:17:07.221000Z TestFramework (ERROR): 
2024-11-30T22:17:07.221000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-30T22:17:07.221000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-11-30T22:17:07.221000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: chronik_plugin_groups.py ======

------- Stdout: -------
2024-11-30T22:15:51.852000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_plugin_groups_107
2024-11-30T22:15:56.163000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 148, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 138, in _run_test_internal
    self.run_test()
  File "/work/test/functional/chronik_plugin_groups.py", line 98, in run_test
    assert_equal(
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    raise AssertionError(
AssertionError: not(400: Requested page size 51 is too big,
        maximum is 50 == 400: Requested page size 51 is too big, maximum is 50)
2024-11-30T22:15:56.214000Z TestFramework (INFO): Stopping nodes
2024-11-30T22:15:56.616000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_plugin_groups_107
2024-11-30T22:15:56.616000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_plugin_groups_107/test_framework.log
2024-11-30T22:15:56.616000Z TestFramework (ERROR): 
2024-11-30T22:15:56.616000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_plugin_groups_107' to consolidate all logs
2024-11-30T22:15:56.616000Z TestFramework (ERROR): 
2024-11-30T22:15:56.616000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-30T22:15:56.616000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-11-30T22:15:56.616000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: chronik_script_confirmed_txs.py ======

------- Stdout: -------
2024-11-30T22:15:38.284000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_script_confirmed_txs_95
2024-11-30T22:15:39.980000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 148, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 138, in _run_test_internal
    self.run_test()
  File "/work/test/functional/chronik_script_confirmed_txs.py", line 76, in run_test
    assert_equal(
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    raise AssertionError(
AssertionError: not(400: Requested page size 201 is too big,
        maximum is 200 == 400: Requested page size 201 is too big, maximum is 200)
2024-11-30T22:15:40.034000Z TestFramework (INFO): Stopping nodes
2024-11-30T22:15:40.336000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_script_confirmed_txs_95
2024-11-30T22:15:40.336000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_script_confirmed_txs_95/test_framework.log
2024-11-30T22:15:40.336000Z TestFramework (ERROR): 
2024-11-30T22:15:40.337000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_script_confirmed_txs_95' to consolidate all logs
2024-11-30T22:15:40.337000Z TestFramework (ERROR): 
2024-11-30T22:15:40.337000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-30T22:15:40.337000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-11-30T22:15:40.338000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: chronik_script_history.py ======

------- Stdout: -------
2024-11-30T22:16:17.507000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_script_history_126
2024-11-30T22:16:20.519000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 148, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 138, in _run_test_internal
    self.run_test()
  File "/work/test/functional/chronik_script_history.py", line 81, in run_test
    assert_equal(
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    raise AssertionError(
AssertionError: not(400: Requested page size 201 is too big,
        maximum is 200 == 400: Requested page size 201 is too big, maximum is 200)
2024-11-30T22:16:20.570000Z TestFramework (INFO): Stopping nodes
2024-11-30T22:16:20.972000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_script_history_126
2024-11-30T22:16:20.972000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_script_history_126/test_framework.log
2024-11-30T22:16:20.973000Z TestFramework (ERROR): 
2024-11-30T22:16:20.973000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20241130_221105/chronik_script_history_126' to consolidate all logs
2024-11-30T22:16:20.973000Z TestFramework (ERROR): 
2024-11-30T22:16:20.974000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2024-11-30T22:16:20.974000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2024-11-30T22:16:20.974000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: chronik_block_header.py
Bitcoin ABC functional tests: chronik_block_txs.py
Bitcoin ABC functional tests: chronik_blocks.py
Bitcoin ABC functional tests: chronik_plugin_groups.py
Bitcoin ABC functional tests: chronik_script_confirmed_txs.py
Bitcoin ABC functional tests: chronik_script_history.py

hazzarust edited the summary of this revision. (Show Details)

added new line \ so build should work

tobias_ruck added a subscriber: tobias_ruck.
tobias_ruck added inline comments.
chronik/bitcoinsuite-slp/src/slp/error.rs
140–141 ↗(On Diff #51299)

format it like this :)

and then do this at the other places too

This revision now requires changes to proceed.Sun, Dec 1, 00:07
tobias_ruck added inline comments.
chronik/chronik-indexer/src/query/blocks.rs
109 ↗(On Diff #51300)

indents should be multiples of 4 (unless we have the string thing)

117 ↗(On Diff #51300)

here too

chronik/chronik-indexer/src/query/group_history.rs
84 ↗(On Diff #51300)

dito

92 ↗(On Diff #51300)

dito

chronik/chronik-indexer/src/query/plugins.rs
74 ↗(On Diff #51300)

dito

82 ↗(On Diff #51300)

dito

This revision now requires changes to proceed.Sun, Dec 1, 00:29