Page MenuHomePhabricator

[cmake] Check for unused command line arguments using the C compiler
ClosedPublic

Authored by Fabien on Tue, Dec 3, 09:48.

Details

Summary

We are currently checking using the c++ compiler, independently of the language used. This breaks the build for libsecp256k1 which has no c++ support.
We could switch the check depending on the project language but it's simpler (and faster) to just use the C compiler instead and assume it will be available also for the c++ one.

Test Plan

With clang and gcc:

ninja all check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_secp_unused_arg
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31496
Build 62489: Build Diffbuild-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 62488: arc lint + arc unit