[64-bit ints] Move `{Add,Sub}Int63Overflow(Emulated)` impl to cpp file
ClosedPublic
Actions

Authored by tobias_ruck on Oct 25 2024, 07:48.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC805a0f137bf6: [64-bit ints] Move `{Add,Sub}Int63Overflow(Emulated)` impl to cpp file

Summary

Currently, importing these generates a lot of warning: unused function, so we move the impl to their own cpp files, and turn intmath.h into just a normal header file without impl.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

move-intmath-header

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31514
Build 62525: Build Diff	build-diff · build-clang · build-clang-tidy · build-debug · lint-circular-dependencies · build-without-wallet
Build 62524: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Oct 25 2024, 07:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 25 2024, 07:48

Harbormaster completed remote builds in B30832: Diff 50425.Oct 25 2024, 08:21

tobias_ruck published this revision for review.Oct 25 2024, 08:55

tobias_ruck added a child revision: D17001: [64-bit ints] Add overflow checks to CScriptNum for +, -, +=, -=.Oct 25 2024, 09:55

Fabien requested changes to this revision.Oct 25 2024, 12:37

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/script/intmath.cpp
1 ↗	(On Diff #50425)
4 ↗	(On Diff #50425)	nope
10 ↗	(On Diff #50425)	move it first: #include <script/intmath.h> #include <cstdlib> #include <limits>
26 ↗	(On Diff #50425)	This probably never worked to begin with, because you're missing the config include snippet: #if defined(HAVE_CONFIG_H) #include <config/bitcoin-config.h> #endif
60 ↗	(On Diff #50425)	dito
src/script/intmath.h
7 ↗	(On Diff #50425)	I don't think you need this one, but you might want cstdint