Page MenuHomePhabricator
Differential D17313

[bitcoin-abc][web] Moved explorer dockerfile to root so it can access Cargo.lock
ClosedPublic
Actions

Authored by hazzarust on Sat, Dec 7, 14:36.

Details

Reviewers
tobias_ruck
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCb0f2a6d08e1e: [bitcoin-abc][web] Moved explorer dockerfile to root so it can access Cargo.lock
Summary

We move the dockerfile out of bitcoin-abc/web/explorer and into bitcoin-abc so that Cargo.lock is in the docker context. Then changed the build-configurations file to include the explorer.Dockerfile in the preview-explorer build

Test Plan

ninja check-functional @bot preview-explorer

Diff Detail

Repository
rABC Bitcoin ABC
Branch
docker_moved
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31571
Build 62639: Build Diff
Build 62638: arc lint + arc unit

Event Timeline

hazzarust created this revision.Sat, Dec 7, 14:36
Owners added a reviewer: Restricted Owners Package.Sat, Dec 7, 14:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Dec 7, 14:36
hazzarust requested review of this revision.Sat, Dec 7, 14:36
Harbormaster completed remote builds in B31571: Diff 51469.Sat, Dec 7, 14:36
hazzarust edited the test plan for this revision. (Show Details)Sat, Dec 7, 14:38
tobias_ruck added a subscriber: tobias_ruck.Sat, Dec 7, 14:59

@bot preview-explorer

teamcity awarded a token.Sat, Dec 7, 14:59
teamcity added a comment.Sat, Dec 7, 15:01

Build Bitcoin ABC Diffs / Diff Testing (preview-explorer) passed.
Preview is available at http://51.178.130.230:41946 for the next 60 minutes.

tobias_ruck accepted this revision.Sat, Dec 7, 15:05
This revision is now accepted and ready to land.Sat, Dec 7, 15:05
Closed by commit rABCb0f2a6d08e1e: [bitcoin-abc][web] Moved explorer dockerfile to root so it can access Cargo.lock (authored by hazzarust). · Explain WhySat, Dec 7, 16:23
This revision was automatically updated to reflect the committed changes.
hazzarust added a commit: rABCb0f2a6d08e1e: [bitcoin-abc][web] Moved explorer dockerfile to root so it can access Cargo.lock.

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
2 lines
explorer.Dockerfile/
web/
explorer/
Dockerfile
4 lines
web/
explorer/

Diff 51469

View Options

contrib/teamcity/build-configurations.yml

Loading...
View Options

explorer.Dockerfile

Loading...
View Options

web/explorer/Dockerfile

Loading...