Differential D17344

[e.cash] Add Pay2Stay to Use eCash page
ClosedPublic
Actions

Authored by Mengerian on Thu, Dec 12, 21:31.

Details

Reviewers

Kronkmeister

Group Reviewers

Restricted Project

Commits

rABC0ff417889439: [e.cash] Add Pay2Stay to Use eCash page

Summary

Pay2Stay are launching and promoting themselves, so good time to add them to the site.

Test Plan

Ran it locally, checked the link.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

e.cash-add-pay2stay

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31633
Build 62763: Build Diff
Build 62762: arc lint + arc unit

Event Timeline

Mengerian created this revision.Thu, Dec 12, 21:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Dec 12, 21:31

Mengerian requested review of this revision.Thu, Dec 12, 21:31

Harbormaster completed remote builds in B31632: Diff 51562.Thu, Dec 12, 21:31

@bot preview-e.cash

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41084 for the next 60 minutes.

Any reason for the selected ordering ? Poker first then pay2stay then paybutton ?

web/e.cash/pages/use-ecash.js
169 ↗	(On Diff #51562)	This should open in a new tab

tested and approved 💪

This revision is now accepted and ready to land.Thu, Dec 12, 21:48

In D17344#394125, @Fabien wrote:

Any reason for the selected ordering ?

No reason, just randomly put it there.
Happy to change the order if you think another order is better

web/e.cash/pages/use-ecash.js
169 ↗	(On Diff #51562)	I asked @johnkuney to fix this, can be done in another Diff

Fabien added inline comments.Thu, Dec 12, 21:58

web/e.cash/pages/use-ecash.js
147 ↗	(On Diff #51562)	This is what you need

Open link in new tab
Change order

Harbormaster completed remote builds in B31633: Diff 51563.Thu, Dec 12, 22:03

Closed by commit rABC0ff417889439: [e.cash] Add Pay2Stay to Use eCash page (authored by Mengerian). · Explain WhyThu, Dec 12, 22:08

This revision was automatically updated to reflect the committed changes.

Mengerian added a commit: rABC0ff417889439: [e.cash] Add Pay2Stay to Use eCash page.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

pages/

use-ecash.js

28 lines

public/

images/

Pay2Stay.png

Diff 51563

View Options

web/e.cash/pages/use-ecash.js