Page MenuHomePhabricator
Differential D17356

[chronik] add electrum method blockchain.transaction.get_height
ClosedPublic
Actions

Authored by PiRK on Sat, Dec 14, 21:40.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCbdfd881df17c: [chronik] add electrum method blockchain.transaction.get_height
Summary

As per title.
Also refactor some boilerplate code into TxId::TryFrom<serde_json::Value>

Depends on D17347
Ref T3598

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sat, Dec 14, 21:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Dec 14, 21:40
PiRK requested review of this revision.Sat, Dec 14, 21:40
PiRK planned changes to this revision.Sat, Dec 14, 21:42

Let's wait to see if tests pass on CI or we get port collisions. The direct parent diff is a draft, this one was supposed to be one too.

Harbormaster completed remote builds in B31657: Diff 51594.Sat, Dec 14, 21:48
teamcity added a comment.Sat, Dec 14, 21:48
Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.

Tail of the build log:

   Doc-tests chronik-bridge

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-db

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-http

running 1 test
test chronik/chronik-http/src/protobuf.rs - protobuf::Protobuf (line 29) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.44s

   Doc-tests chronik-indexer

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-common

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-impl

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-proto

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-util

running 2 tests
test chronik/chronik-util/src/log.rs - log::log (line 65) ... ignored
test chronik/chronik-util/src/log.rs - log::log_chronik (line 87) ... ignored

test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.00s

ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik failed with exit code 1
teamcity added a comment.Sat, Dec 14, 21:52
Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.

Tail of the build log:

   Doc-tests chronik-bridge

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-db

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-http

running 1 test
test chronik/chronik-http/src/protobuf.rs - protobuf::Protobuf (line 29) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.36s

   Doc-tests chronik-indexer

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-common

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-impl

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-proto

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-util

running 2 tests
test chronik/chronik-util/src/log.rs - log::log (line 65) ... ignored
test chronik/chronik-util/src/log.rs - log::log_chronik (line 87) ... ignored

test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.00s

ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik-plugins failed with exit code 1
PiRK updated this revision to Diff 51618.Mon, Dec 16, 13:28

do this without the macro from D17355 (need to study macros more to make it work), fix clippy::needless-question-mark

PiRK edited the summary of this revision. (Show Details)Mon, Dec 16, 13:37
PiRK added a parent revision: D17347: [chronik] add macros to extract params from a JSONRPC request.
PiRK removed a parent revision: D17355: [chronik] add a macro to define an electrum method.
Harbormaster completed remote builds in B31678: Diff 51618.Mon, Dec 16, 13:38
teamcity added a comment.Mon, Dec 16, 13:38
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #N/A, branch 'refs/tags/phabricator/diff/51618'
Triggered 2024-12-16 13:28:13 by 'Phabricator Staging (phabricator-staging)'
Started 2024-12-16 13:38:46 on agent 'N/A'
Finished 2024-12-16 13:38:46 with status FAILURE 'Snapshot dependency failed to start: Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout'
VCS revisions: 'BitcoinABC_BitcoinAbcStaging' (Git, instance id 22): 'c940f42c806061b9554e62822643bc377eb3d79e' (branch: 'refs/tags/phabricator/diff/51618', checkout rules: '+:. => ./bitcoin-abc')
TeamCity URL https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/870891 
TeamCity server version is 2024.12 (build 174331), server timezone: GMT (UTC)

[13:28:13]W: bt15 (10m:33s)
[13:28:13]i: TeamCity server version is 2024.12 (build 174331)
[13:28:13] : Finalize build settings
[13:28:13] : Collecting changes in 2 VCS roots
[13:28:13] :	 [Collecting changes in 2 VCS roots] VCS Root details
[13:28:13] :		 [VCS Root details] "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[13:28:13] :		 [VCS Root details] "abc-infrastructure" {instance id=24, parent internal id=7, parent id=AutomatedDeployments_BitcoinAbcDeveloperTools_AbcInfrastructure, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/infrastructure.git#refs/heads/master"}
[13:28:13]i: Loading current repository state for VCS root 'Bitcoin ABC Staging' (6s)
[13:28:13]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] VCS root 'Bitcoin ABC Staging': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper11884057011158320471.sh ls-remote origin
[13:28:13]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] Loading current repository state for VCS root 'abc-infrastructure' (6s)
[13:28:13]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper16802268983078207767.sh ls-remote origin
[13:28:13]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[13:28:13]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': kex_exchange_identification: Connection closed by remote host
[13:28:13]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Connection closed by 51.161.87.173 port 2221
[13:28:13]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': fatal: Could not read from remote repository.
[13:28:13]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': 
[13:28:13]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Please make sure you have the correct access rights
[13:28:13]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': and the repository exists.
[13:28:14]i: Waiting for completion of current operations for the VCS root 'Bitcoin ABC Staging'
[13:28:20]i: Detecting changes in VCS root 'Bitcoin ABC Staging' (used in 'Diff Testing', 'Staging Checkout Dummy')
[13:28:20]i: Will collect changes for 'Bitcoin ABC Staging' starting from revision 9b4c6905cbae455469f4fd065885cbd104369052
[13:28:20] : Compute revision for 'Bitcoin ABC Staging'
[13:28:20] :	 [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: c940f42c806061b9554e62822643bc377eb3d79e
[13:28:20]i:	 [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 76674
[13:28:20] :	 [Compute revision for 'Bitcoin ABC Staging'] Computed revision: c940f42c806061b9554e62822643bc377eb3d79e
[13:38:46]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start
PiRK planned changes to this revision.Mon, Dec 16, 13:47

Collision on port 33380, Lets try to reduce the port range first to not conflict with docker ports (see D16048)

PiRK updated this revision to Diff 51626.Mon, Dec 16, 14:06

rebase after reducing the port range in D17314

Harbormaster completed remote builds in B31683: Diff 51626.Mon, Dec 16, 15:00
teamcity added a comment.Mon, Dec 16, 15:00
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #N/A, branch 'refs/tags/phabricator/diff/51626'
Triggered 2024-12-16 14:06:37 by 'Phabricator Staging (phabricator-staging)'
Started 2024-12-16 14:59:59 on agent 'N/A'
Finished 2024-12-16 14:59:59 with status FAILURE 'Snapshot dependency failed to start: Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout'
VCS revisions: 'BitcoinABC_BitcoinAbcStaging' (Git, instance id 22): 'f4e0938deb8787065a716dbdf31507ec1be06bb8' (branch: 'refs/tags/phabricator/diff/51626', checkout rules: '+:. => ./bitcoin-abc')
TeamCity URL https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/871149 
TeamCity server version is 2024.12 (build 174331), server timezone: GMT (UTC)

[14:06:37]W: bt15 (53m:21s)
[14:06:37]i: TeamCity server version is 2024.12 (build 174331)
[14:06:37] : Finalize build settings
[14:06:37] : Collecting changes in 2 VCS roots
[14:06:37] :	 [Collecting changes in 2 VCS roots] VCS Root details
[14:06:37] :		 [VCS Root details] "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[14:06:37] :		 [VCS Root details] "abc-infrastructure" {instance id=24, parent internal id=7, parent id=AutomatedDeployments_BitcoinAbcDeveloperTools_AbcInfrastructure, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/infrastructure.git#refs/heads/master"}
[14:06:37]i: Loading current repository state for VCS root 'Bitcoin ABC Staging' (7s)
[14:06:37]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] Loading current repository state for VCS root 'abc-infrastructure' (7s)
[14:06:37]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper13662617034917507541.sh ls-remote origin
[14:06:37]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper6099194039805448590.sh ls-remote origin
[14:06:37]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': kex_exchange_identification: read: Connection reset by peer
[14:06:37]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Connection reset by 51.161.87.173 port 2221
[14:06:37]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': fatal: Could not read from remote repository.
[14:06:37]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': 
[14:06:37]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Please make sure you have the correct access rights
[14:06:37]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': and the repository exists.
[14:06:37]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[14:06:38]i: Waiting for completion of current operations for the VCS root 'Bitcoin ABC Staging'
[14:06:45]i: Detecting changes in VCS root 'Bitcoin ABC Staging' (used in 'Diff Testing', 'Staging Checkout Dummy')
[14:06:45]i: Will collect changes for 'Bitcoin ABC Staging' starting from revision 26ca7aa70c44ef8aafeec0bf611a8e26556776cf
[14:06:45] : Compute revision for 'Bitcoin ABC Staging'
[14:06:45] :	 [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: f4e0938deb8787065a716dbdf31507ec1be06bb8
[14:06:45]i:	 [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 76693
[14:06:45] :	 [Compute revision for 'Bitcoin ABC Staging'] Computed revision: f4e0938deb8787065a716dbdf31507ec1be06bb8
[14:59:59]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start
PiRK updated this revision to Diff 51635.Mon, Dec 16, 16:07

take a reference for TryFrom, use it also in transaction_get (minor behavior change in the error message, because now we have one less line that can raise a variant on the same error message)

PiRK updated this revision to Diff 51636.Mon, Dec 16, 16:12

use is_none() isntead of match

Harbormaster completed remote builds in B31688: Diff 51635.Mon, Dec 16, 16:15
teamcity added a comment.Mon, Dec 16, 16:15
Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.

Tail of the build log:

   Doc-tests chronik-bridge

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-db

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-http

running 1 test
test chronik/chronik-http/src/protobuf.rs - protobuf::Protobuf (line 29) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.38s

   Doc-tests chronik-indexer

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-common

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-impl

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-proto

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-util

running 2 tests
test chronik/chronik-util/src/log.rs - log::log (line 65) ... ignored
test chronik/chronik-util/src/log.rs - log::log_chronik (line 87) ... ignored

test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.00s

ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik failed with exit code 1
teamcity added a comment.Mon, Dec 16, 16:17
Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.

Tail of the build log:

   Doc-tests chronik-bridge

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-db

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-http

running 1 test
test chronik/chronik-http/src/protobuf.rs - protobuf::Protobuf (line 29) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.37s

   Doc-tests chronik-indexer

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-common

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-impl

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-proto

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-util

running 2 tests
test chronik/chronik-util/src/log.rs - log::log (line 65) ... ignored
test chronik/chronik-util/src/log.rs - log::log_chronik (line 87) ... ignored

test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.00s

ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik-plugins failed with exit code 1
Harbormaster completed remote builds in B31689: Diff 51636.Mon, Dec 16, 16:23
teamcity added a comment.Mon, Dec 16, 16:23
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #N/A, branch 'refs/tags/phabricator/diff/51636'
Triggered 2024-12-16 16:12:41 by 'Phabricator Staging (phabricator-staging)'
Started 2024-12-16 16:23:53 on agent 'N/A'
Finished 2024-12-16 16:23:53 with status FAILURE 'Snapshot dependency failed to start: Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout'
VCS revisions: 'BitcoinABC_BitcoinAbcStaging' (Git, instance id 22): 'b67f309b571481b1dbebd1ddfee9585d2c643885' (branch: 'refs/tags/phabricator/diff/51636', checkout rules: '+:. => ./bitcoin-abc')
TeamCity URL https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/871386 
TeamCity server version is 2024.12 (build 174331), server timezone: GMT (UTC)

[16:12:41]W: bt15 (11m:12s)
[16:12:41]i: TeamCity server version is 2024.12 (build 174331)
[16:12:41] : Finalize build settings
[16:12:41] : Collecting changes in 2 VCS roots
[16:12:41] :	 [Collecting changes in 2 VCS roots] VCS Root details
[16:12:41] :		 [VCS Root details] "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[16:12:41] :		 [VCS Root details] "abc-infrastructure" {instance id=24, parent internal id=7, parent id=AutomatedDeployments_BitcoinAbcDeveloperTools_AbcInfrastructure, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/infrastructure.git#refs/heads/master"}
[16:12:41]i: Loading current repository state for VCS root 'Bitcoin ABC Staging' (7s)
[16:12:41]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] VCS root 'Bitcoin ABC Staging': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper6758829400295442124.sh ls-remote origin
[16:12:41]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] Loading current repository state for VCS root 'abc-infrastructure' (7s)
[16:12:41]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper6143963405793045431.sh ls-remote origin
[16:12:41]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': kex_exchange_identification: Connection closed by remote host
[16:12:41]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Connection closed by 51.161.87.173 port 2221
[16:12:41]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': fatal: Could not read from remote repository.
[16:12:41]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': 
[16:12:41]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Please make sure you have the correct access rights
[16:12:41]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': and the repository exists.
[16:12:41]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[16:12:42]i: Waiting for completion of current operations for the VCS root 'Bitcoin ABC Staging'
[16:12:48]i: Detecting changes in VCS root 'Bitcoin ABC Staging' (used in 'Diff Testing', 'Staging Checkout Dummy')
[16:12:48]i: Will collect changes for 'Bitcoin ABC Staging' starting from revision 719ef6251e2e8c36dc9ca94e1b137d65b136cc74
[16:12:48] : Compute revision for 'Bitcoin ABC Staging'
[16:12:48] :	 [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: b67f309b571481b1dbebd1ddfee9585d2c643885
[16:12:48]i:	 [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 76715
[16:12:48] :	 [Compute revision for 'Bitcoin ABC Staging'] Computed revision: b67f309b571481b1dbebd1ddfee9585d2c643885
[16:23:53]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start
teamcity added a comment.Mon, Dec 16, 16:24
Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.

Tail of the build log:

   Doc-tests chronik-bridge

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-db

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-http

running 1 test
test chronik/chronik-http/src/protobuf.rs - protobuf::Protobuf (line 29) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.39s

   Doc-tests chronik-indexer

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-common

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-impl

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-proto

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-util

running 2 tests
test chronik/chronik-util/src/log.rs - log::log (line 65) ... ignored
test chronik/chronik-util/src/log.rs - log::log_chronik (line 87) ... ignored

test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.00s

ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik failed with exit code 1
teamcity added a comment.Mon, Dec 16, 16:30
Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.

Tail of the build log:

   Doc-tests chronik-bridge

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-db

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-http

running 1 test
test chronik/chronik-http/src/protobuf.rs - protobuf::Protobuf (line 29) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.37s

   Doc-tests chronik-indexer

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-common

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-impl

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-proto

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-util

running 2 tests
test chronik/chronik-util/src/log.rs - log::log (line 65) ... ignored
test chronik/chronik-util/src/log.rs - log::log_chronik (line 87) ... ignored

test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.00s

ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik-plugins failed with exit code 1
PiRK planned changes to this revision.Mon, Dec 16, 18:24

Not sure why the build claims serde_json:: Value is unused in txid.rs, will investigate

PiRK updated this revision to Diff 51639.Tue, Dec 17, 07:56

so it looks like we don't need to use serde_json::Value; in the module that implement try_from(value: &'_ serde_json::Value), but we still need to have the crate as a depencency (Cargo.[toml/lock])

Harbormaster completed remote builds in B31692: Diff 51639.Tue, Dec 17, 08:19
Fabien requested changes to this revision.Tue, Dec 17, 10:10
Fabien added a subscriber: Fabien.
Fabien added inline comments.
chronik/bitcoinsuite-core/src/tx/txid.rs
145–151 ↗(On Diff #51639)

The fact that it's wrapped in a Univalue like type is an implementation detail and should not appear in an error message

chronik/chronik-http/src/electrum.rs
335 ↗(On Diff #51639)

Nit: group the txid processing together then process the verbose flag

337–339 ↗(On Diff #51639)

I leave that up to you. This lets you have both the errors reachable but the error message is a bit less consistent

371 ↗(On Diff #51639)

This can be None, you don't want that. Since you already decoded the txid, just use that instead: txid.to_string()

386 ↗(On Diff #51639)

dito

397 ↗(On Diff #51639)

see above comment

407–412 ↗(On Diff #51639)

Same here, it's just more obvious that tx.block is an Option with that form

test/functional/chronik_electrum_blockchain.py
85 ↗(On Diff #51639)

You don't need that change (except txid vs TxId) with the above map_err suggestion

145 ↗(On Diff #51639)

Test for unknown tx ?

This revision now requires changes to proceed.Tue, Dec 17, 10:10
PiRK updated this revision to Diff 51641.Tue, Dec 17, 11:22

feedback

Harbormaster completed remote builds in B31693: Diff 51641.Tue, Dec 17, 11:22
teamcity added a comment.Tue, Dec 17, 11:22
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #N/A, branch 'refs/tags/phabricator/diff/51641'
Triggered 2024-12-17 11:22:39 by 'Phabricator Staging (phabricator-staging)'
Started 2024-12-17 11:22:46 on agent 'N/A'
Finished 2024-12-17 11:22:46 with status FAILURE 'Snapshot dependency failed to start: Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout'
VCS revisions: 'BitcoinABC_BitcoinAbcStaging' (Git, instance id 22): '576020561a64fb49a0b57411738ebddd7fe55de1' (branch: 'refs/tags/phabricator/diff/51641', checkout rules: '+:. => ./bitcoin-abc')
TeamCity URL https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/871566 
TeamCity server version is 2024.12 (build 174331), server timezone: GMT (UTC)

[11:22:39]W: bt15 (6s)
[11:22:39]i: TeamCity server version is 2024.12 (build 174331)
[11:22:39] : Finalize build settings
[11:22:39] : Collecting changes in 2 VCS roots
[11:22:39] :	 [Collecting changes in 2 VCS roots] VCS Root details
[11:22:39] :		 [VCS Root details] "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[11:22:39] :		 [VCS Root details] "abc-infrastructure" {instance id=24, parent internal id=7, parent id=AutomatedDeployments_BitcoinAbcDeveloperTools_AbcInfrastructure, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/infrastructure.git#refs/heads/master"}
[11:22:39]i: Loading current repository state for VCS root 'Bitcoin ABC Staging' (6s)
[11:22:39]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] Loading current repository state for VCS root 'abc-infrastructure' (6s)
[11:22:39]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper16922254862672927309.sh ls-remote origin
[11:22:39]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper15396537617556134371.sh ls-remote origin
[11:22:39]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': kex_exchange_identification: Connection closed by remote host
[11:22:39]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Connection closed by 51.161.87.173 port 2221
[11:22:39]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': fatal: Could not read from remote repository.
[11:22:39]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': 
[11:22:39]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Please make sure you have the correct access rights
[11:22:39]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': and the repository exists.
[11:22:39]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[11:22:40]i: Waiting for completion of current operations for the VCS root 'Bitcoin ABC Staging'
[11:22:46]i: Detecting changes in VCS root 'Bitcoin ABC Staging' (used in 'Diff Testing', 'Staging Checkout Dummy')
[11:22:46]i: Will collect changes for 'Bitcoin ABC Staging' starting from revision 10d026eb1e67e9b86d9e7f03bc9bbc2e8c551e46
[11:22:46] : Compute revision for 'Bitcoin ABC Staging'
[11:22:46] :	 [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: 576020561a64fb49a0b57411738ebddd7fe55de1
[11:22:46]i:	 [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 76723
[11:22:46] :	 [Compute revision for 'Bitcoin ABC Staging'] Computed revision: 576020561a64fb49a0b57411738ebddd7fe55de1
[11:22:46]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start
PiRK added inline comments.Tue, Dec 17, 11:25
test/functional/chronik_electrum_blockchain.py
148 ↗(On Diff #51641)

I'm going to change this error code to something else than 32600 (in a different diff)

The spec says

-32700 Parse error Invalid JSON was received by the server.
An error occurred on the server while parsing the JSON text.
-32600 Invalid Request The JSON sent is not a valid Request object.
-32601 Method not found The method does not exist / is not available.
-32602 Invalid params Invalid method parameter(s).
-32603 Internal error Internal JSON-RPC error.
-32000 to -32099 Server error Reserved for implementation-defined server-errors.

So either we should use a generic 32602 (invalid params) or start implementing some RPCError::CustomError codes.

PiRK edited the summary of this revision. (Show Details)Tue, Dec 17, 11:27
PiRK added a task: Restricted Maniphest Task.
teamcity added a comment.Tue, Dec 17, 11:30
Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.

Tail of the build log:

   Doc-tests chronik-bridge

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-db

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-http

running 1 test
test chronik/chronik-http/src/protobuf.rs - protobuf::Protobuf (line 29) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.38s

   Doc-tests chronik-indexer

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-common

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-plugin-impl

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-proto

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-util

running 2 tests
test chronik/chronik-util/src/log.rs - log::log (line 65) ... ignored
test chronik/chronik-util/src/log.rs - log::log_chronik (line 87) ... ignored

test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.00s

ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik failed with exit code 1
teamcity added a comment.Tue, Dec 17, 11:32
Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.

Tail of the build log:

   Compiling bitcoinsuite-slp v0.1.0 (/work/chronik/bitcoinsuite-slp)
   Compiling abc-rust-error v0.1.0 (/work/chronik/abc-rust-error)
   Compiling toml v0.8.19
   Compiling chronik-plugin-common v0.1.0 (/work/chronik/chronik-plugin-common)
   Compiling chronik-plugin-impl v0.1.0 (/work/chronik/chronik-plugin-impl)
   Compiling chronik-plugin v0.1.0 (/work/chronik/chronik-plugin)
   Compiling rocksdb v0.21.0
   Compiling chronik-db v0.1.0 (/work/chronik/chronik-db)
    Finished test [unoptimized + debuginfo] target(s) in 7m 36s
     Running unittests src/lib.rs (abc-ci-builds/build-chronik-plugins/cargo/build/debug/deps/chronik_db-8ec6334bdcc83f36)

running 37 tests
test index_tx::tests::test_tx_num_cache ... ok
test groups::script::tests::test_script_group ... ok
test io::group_utxos::tests::test_value_group_utxos ... ok
test io::block_stats::tests::test_block_stats ... ok
test io::token::tests::test_batch_burn::test_batch_burn ... ok
test io::group_history::tests::test_value_group_history ... ok
test io::token::tests::test_batch_common::test_batch_topological_sort ... ok
test io::token::tests::test_batch_common::test_batch_cycle ... ok
test io::token::tests::test_batch_alp::test_batch_alp ... ok
test io::merge::tests::test_catch_merge ... ok
test mem::group_history::tests::test_mempool_group_history ... ok
test mem::group_utxos::tests::test_mempool_group_utxos ... ok
test mem::spent_by::tests::test_mempool_spent_by ... ok
test io::token::tests::test_batch_common::test_batch_skip_validation ... ok
test io::token::tests::test_batch_disconnect_block::test_batch_disconnect ... ok
test io::token::tests::test_batch_genesis::test_batch_genesis_alp ... ok
test io::token::tests::test_batch_genesis::test_batch_genesis_slp_fungible ... ok
test io::token::tests::test_batch_vault::test_batch_vault ... ok
test io::spent_by::tests::test_spent_by ... ok
test ser::tests::test_deserialize_leftover_err ... ok
test ser::tests::test_err_display_deserialize ... ok
test ser::tests::test_err_display_deserialize_leftover ... ok
test ser::tests::test_err_display_serialize ... ok
test ser::tests::test_roundtrip ... ok
test ser::tests::test_roundtrip_vec ... ok
test ser::tests::test_serialize_err ... ok
test ser::tests::test_deserialize_err ... ok
test io::token::tests::test_batch_unknown::test_batch_unknown ... ok
test io::token::tests::test_batch_nft::test_batch_slp_nft1 ... ok
test plugins::io::tests::test_plugin_metas ... ok
test reverse_lookup::tests::test_reverse_lookup ... ok
test mem::tokens::tests::test_mempool_tokens ... ok
test plugins::io::tests::test_plugin_writer ... ok
test index_tx::tests::test_prepare_indexed_txs ... ok
test io::blocks::tests::test_blocks ... ok
test io::txs::tests::test_insert_txs ... ok
test reverse_lookup::tests::test_reverse_lookup_rng ... ok

test result: ok. 37 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.34s

   Doc-tests chronik-db

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik-plugins failed with exit code 1
PiRK updated this revision to Diff 51642.Tue, Dec 17, 12:41

address clippy's complaint

Harbormaster completed remote builds in B31694: Diff 51642.Tue, Dec 17, 12:58
Fabien accepted this revision.Tue, Dec 17, 13:29
This revision is now accepted and ready to land.Tue, Dec 17, 13:29
Closed by commit rABCbdfd881df17c: [chronik] add electrum method blockchain.transaction.get_height (authored by PiRK). · Explain WhyTue, Dec 17, 14:28
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCbdfd881df17c: [chronik] add electrum method blockchain.transaction.get_height.

Revision Contents
Changeset List

PathSize
chronik/
bitcoinsuite-core/
3 lines
src/
tx/
14 lines
chronik-http/
src/
40 lines
test/
functional/
38 lines

Diff 51645

View Options

Cargo.lock

Loading...
View Options

chronik/bitcoinsuite-core/Cargo.toml

Loading...
View Options

chronik/bitcoinsuite-core/src/tx/txid.rs

Loading...
View Options

chronik/chronik-http/src/electrum.rs

Loading...
View Options

test/functional/chronik_electrum_blockchain.py

Loading...