Page MenuHomePhabricator
Differential D17383

[Cashtab] Use user modal confirmation settings for minting tokens
ClosedPublic
Actions

Authored by bytesofman on Sat, Dec 21, 23:52.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC9fa101265182: [Cashtab] Use user modal confirmation settings for minting tokens
Summary

T3709

Currently there is no confirmation on mint txs.

imo Mint is not the kind of action that always needs a confirmation (like burn). So, defer to user settings on this.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
mint-confirm
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31738
Build 62970: Build Diffcashtab-tests
Build 62969: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sat, Dec 21, 23:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Dec 21, 23:52
Harbormaster completed remote builds in B31737: Diff 51710.Sat, Dec 21, 23:56
bytesofman updated this revision to Diff 51711.Sun, Dec 22, 00:15

confirm behavior with test

bytesofman edited the test plan for this revision. (Show Details)Sun, Dec 22, 00:15
Harbormaster completed remote builds in B31738: Diff 51711.Sun, Dec 22, 00:19
bytesofman published this revision for review.Sun, Dec 22, 00:31
emack accepted this revision.Sun, Dec 22, 09:45
emack added a subscriber: emack.
emack added inline comments.
cashtab/src/components/Etokens/__tests__/Token.test.js
967

how do you simulate this environment var in int tests?

This revision is now accepted and ready to land.Sun, Dec 22, 09:45
bytesofman marked an inline comment as done.Sun, Dec 22, 11:39
bytesofman added inline comments.
cashtab/src/components/Etokens/__tests__/Token.test.js
967

you can see in the earlier steps of this test that we render the app rather than only the token route -- navigate to settings, enable this setting, and then navigate to the token page.

Closed by commit rABC9fa101265182: [Cashtab] Use user modal confirmation settings for minting tokens (authored by bytesofman). · Explain WhySun, Dec 22, 11:39
This revision was automatically updated to reflect the committed changes.
bytesofman marked an inline comment as done.
bytesofman added a commit: rABC9fa101265182: [Cashtab] Use user modal confirmation settings for minting tokens.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Etokens/
Token/
31 lines
__tests__/
150 lines

Diff 51711

View Options

cashtab/src/components/Etokens/Token/index.tsx

Loading...
View Options

cashtab/src/components/Etokens/__tests__/Token.test.js

Loading...