Page MenuHomePhabricator
Differential D1842

bench: use std::chrono rather than gettimeofday
ClosedPublic
Actions

Authored by deadalnix on Sep 30 2018, 13:59.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING92d96043ced5: bench: use std::chrono rather than gettimeofday
rABC92d96043ced5: bench: use std::chrono rather than gettimeofday
Summary
  • bench: switch to std::chrono for time measurements

std::chrono removes portability issues.

Rather than storing doubles, store the untouched time_points. Then
convert to nanoseconds for display. This allows for maximum precision, while
keeping results comparable between differing hardware/operating systems.

Also, display full nanosecond counts rather than sub-second floats.

  • bench: prefer a steady clock if the resolution is no worse
  • Require a steady clock for bench with at least micro precision

This is a backport of core PR11562 and PR11646

Test Plan
make
./src/bench/bench_bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 30 2018, 13:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2018, 13:59
teamcity added a subscriber: teamcity.Sep 30 2018, 14:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 5183.Sep 30 2018, 14:09

Also include core PR11646

deadalnix edited the summary of this revision. (Show Details)Sep 30 2018, 14:10
teamcity added a comment.Sep 30 2018, 14:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3448: Diff 5182.Sep 30 2018, 14:18
teamcity added a comment.Sep 30 2018, 14:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3449: Diff 5183.Sep 30 2018, 14:29
teamcity added a comment.Sep 30 2018, 14:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D1844: Tests: Improve benchmark precision.Sep 30 2018, 14:52
jasonbcox accepted this revision.Sep 30 2018, 16:53
This revision is now accepted and ready to land.Sep 30 2018, 16:53
Closed by commit rABC92d96043ced5: bench: use std::chrono rather than gettimeofday (authored by Cory Fields <cory-nospam-@coryfields.com>, committed by deadalnix). · Explain WhySep 30 2018, 16:54
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
bench/
29 lines
54 lines
12 lines

Diff 5193

View Options

src/bench/bench.h

Loading...
View Options

src/bench/bench.cpp

Loading...
View Options

src/bench/rollingbloom.cpp

Loading...