HomePhabricator

Track negated options in the option parser

Description

Track negated options in the option parser

Summary:

  • Add additional tests for GetBoolArg()

This is meant to be an intermediate commit to prove that the next does not
introduce any changes in the semantics of boolean option parsing.

  • Track negated arguments in the argument paser.

This commit adds tracking for negated arguments. This change will be used in a
future commit that allows disabling the debug.log file using -nodebuglogfile.

This is a backport of Core's PR12713

Depends on D1832 and D1830

Test Plan:

make check

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: teamcity

Differential Revision: https://reviews.bitcoinabc.org/D1833

Details

Provenance
Evan Klitzke <evan@eklitzke.org>Authored on Mar 22 2018, 02:22
deadalnixCommitted on Sep 29 2018, 08:35
deadalnixPushed on Sep 29 2018, 08:35
Reviewer
Restricted Project
Differential Revision
D1833: Track negated options in the option parser
Parents
rABC2ad33bfcd361: Fix constness of ArgsManager methods
Branches
Unknown
Tags
Unknown