Page MenuHomePhabricator

[Cashtab] Patch agora token switch issue
ClosedPublic

Authored by bytesofman on Sat, Jan 11, 14:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCb94164d65fdf: [Cashtab] Patch agora token switch issue
Summary

See T3721 for detailed description

If a user browses agora by manually switching the tokenId in the nav bar, the OrderBook component does not refresh offers with the updated tokenId. Patch.

Test Plan

npm test

https://cashtab-local-dev.netlify.app/

I'm not sure how to directly test this, because react testing library does not support the user manually entering a new route (we would have to do it by clickling links in the app UI, and if we do this we force a refresh of the component and could not recreate the bug)

I've put this up on the test site. You can repeat the bug at cashtab.com now by

if you do the same thing on the test site (with this diff), you will not experience the issue. Hard refresh on load to ensure the latest version.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable