Page MenuHomePhabricator
Differential D17568

[electrum] refactor text completion
ClosedPublic
Actions

Authored by PiRK on Tue, Jan 21, 08:44.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC415850772402: [electrum] refactor text completion
Summary

Move the text completion code from the paytoedit widget into its own class and module, so it can be reused for other widgets such as the seed editor.

This is a partial backport of electrum#4033

Test Plan
python -m electrumabc_gui.qt.completion_text_edit

Run the application and check that auto-completion still works in the Pay-To field (add a few contacts to the wallet)

Diff Detail

Event Timeline

PiRK created this revision.Tue, Jan 21, 08:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jan 21, 08:44
PiRK requested review of this revision.Tue, Jan 21, 08:44
teamcity edited the summary of this revision. (Show Details)Tue, Jan 21, 08:44
Harbormaster completed remote builds in B32170: Diff 52320.Tue, Jan 21, 08:46
PiRK added a child revision: D17569: [electrum] implement autocompletion when restoring from seed.Tue, Jan 21, 09:17
PiRK edited the test plan for this revision. (Show Details)Tue, Jan 21, 12:12
PiRK planned changes to this revision.Tue, Jan 21, 12:22

I may have lost a few Electron Cash improvements in keyPressEvent in the process

PiRK updated this revision to Diff 52324.Tue, Jan 21, 12:38

restore https://github.com/Bitcoin-ABC/ElectrumABC/commit/e2d0f7f804a0b805644957f423e04120cff921b3 and https://github.com/Bitcoin-ABC/ElectrumABC/commit/ac0da1446ed153c291b065cd9ef8a20ef561081d

We partially revert https://github.com/Bitcoin-ABC/ElectrumABC/commit/57914d3f764b498554cddf53204b84bffebc5874 (the changes in PayToEdit.keyPressEvent) which is fine since we dropped support for CashAccount

Harbormaster completed remote builds in B32174: Diff 52324.Tue, Jan 21, 12:40
Fabien accepted this revision.Tue, Jan 21, 15:28
This revision is now accepted and ready to land.Tue, Jan 21, 15:28
Closed by commit rABC415850772402: [electrum] refactor text completion (authored by Lastrellik <lastrellik@gmail.com>, committed by PiRK). · Explain WhyTue, Jan 21, 16:32
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC415850772402: [electrum] refactor text completion.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc_gui/
qt/
133 lines
2 lines
72 lines

Diff 52324

View Options

electrum/electrumabc_gui/qt/completion_text_edit.py

Loading...
View Options

electrum/electrumabc_gui/qt/main_window.py

Loading...
View Options

electrum/electrumabc_gui/qt/paytoedit.py

Loading...