Page MenuHomePhabricator
Differential D17573

[electrum] Sign stakes using Trezor devices
DraftPublic
Actions

Authored by Fabien on Tue, Jan 21, 14:22.
This is a draft revision that has not yet been submitted for review.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

TBD

Test Plan

TBD

Diff Detail

Repository
rABC Bitcoin ABC
Branch
electrum_sign_stake_trezor
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32181
Build 63852: Build Diffelectrum-tests
Build 63851: arc lint + arc unit

Event Timeline

Fabien created this revision.Tue, Jan 21, 14:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jan 21, 14:22
Harbormaster completed remote builds in B32177: Diff 52327.Tue, Jan 21, 14:25
teamcity added a comment.Tue, Jan 21, 14:25
Build Bitcoin ABC Diffs / Diff Testing (electrum-tests) failed.

Tail of the build log:

======================================================================
FAIL: test_proof_data (electrumabc.tests.test_avalanche.TestAvalancheProofFromHex.test_proof_data)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/work/electrum/electrumabc/tests/test_avalanche.py", line 445, in test_proof_data
    proof = Proof.from_hex(expected_proof1)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/serialize.py", line 58, in from_hex
    return cls.deserialize(BytesIO(bytes.fromhex(hex_str)))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 221, in deserialize
    return Proof(
           ^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 188, in __init__
    self.limitedid = LimitedProofId.build(
                     ^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 136, in build
    ss += serialize_sequence(stakes)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/serialize.py", line 128, in serialize_sequence
    b += obj.serialize()
         ^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 96, in serialize
    assert self.pubkey
AssertionError

======================================================================
FAIL: test_proofid (electrumabc.tests.test_avalanche.TestAvalancheProofFromHex.test_proofid)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/work/electrum/electrumabc/tests/test_avalanche.py", line 388, in test_proofid
    proof = Proof.from_hex(
            ^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/serialize.py", line 58, in from_hex
    return cls.deserialize(BytesIO(bytes.fromhex(hex_str)))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 221, in deserialize
    return Proof(
           ^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 188, in __init__
    self.limitedid = LimitedProofId.build(
                     ^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 136, in build
    ss += serialize_sequence(stakes)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/serialize.py", line 128, in serialize_sequence
    b += obj.serialize()
         ^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 96, in serialize
    assert self.pubkey
AssertionError

----------------------------------------------------------------------
Ran 334 tests in 30.140s

FAILED (failures=4, errors=4, skipped=4)
Testing `setup.py --version`: OK

ninja: build stopped: cannot make progress due to previous errors.
Build electrum-tests failed with exit code 1
Fabien updated this revision to Diff 52336.Wed, Jan 22, 15:46

It works

Fabien updated this revision to Diff 52337.Wed, Jan 22, 15:48

Back out unrelated changes

Harbormaster completed remote builds in B32181: Diff 52336.Wed, Jan 22, 15:48
teamcity added a comment.Wed, Jan 22, 15:48
Build Bitcoin ABC Diffs / Diff Testing (electrum-tests) failed.

Tail of the build log:

======================================================================
FAIL: test_proof_data (electrumabc.tests.test_avalanche.TestAvalancheProofFromHex.test_proof_data)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/work/electrum/electrumabc/tests/test_avalanche.py", line 445, in test_proof_data
    proof = Proof.from_hex(expected_proof1)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/serialize.py", line 58, in from_hex
    return cls.deserialize(BytesIO(bytes.fromhex(hex_str)))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 221, in deserialize
    return Proof(
           ^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 188, in __init__
    self.limitedid = LimitedProofId.build(
                     ^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 136, in build
    ss += serialize_sequence(stakes)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/serialize.py", line 128, in serialize_sequence
    b += obj.serialize()
         ^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 96, in serialize
    assert self.pubkey
AssertionError

======================================================================
FAIL: test_proofid (electrumabc.tests.test_avalanche.TestAvalancheProofFromHex.test_proofid)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/work/electrum/electrumabc/tests/test_avalanche.py", line 388, in test_proofid
    proof = Proof.from_hex(
            ^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/serialize.py", line 58, in from_hex
    return cls.deserialize(BytesIO(bytes.fromhex(hex_str)))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 221, in deserialize
    return Proof(
           ^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 188, in __init__
    self.limitedid = LimitedProofId.build(
                     ^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 136, in build
    ss += serialize_sequence(stakes)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/serialize.py", line 128, in serialize_sequence
    b += obj.serialize()
         ^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 96, in serialize
    assert self.pubkey
AssertionError

----------------------------------------------------------------------
Ran 334 tests in 22.730s

FAILED (failures=4, errors=5, skipped=4)
Testing `setup.py --version`: OK

ninja: build stopped: cannot make progress due to previous errors.
Build electrum-tests failed with exit code 1
Harbormaster completed remote builds in B32182: Diff 52337.Wed, Jan 22, 15:50
teamcity added a comment.Wed, Jan 22, 15:50
Build Bitcoin ABC Diffs / Diff Testing (electrum-tests) failed.

Tail of the build log:

======================================================================
FAIL: test_proof_data (electrumabc.tests.test_avalanche.TestAvalancheProofFromHex.test_proof_data)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/work/electrum/electrumabc/tests/test_avalanche.py", line 445, in test_proof_data
    proof = Proof.from_hex(expected_proof1)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/serialize.py", line 58, in from_hex
    return cls.deserialize(BytesIO(bytes.fromhex(hex_str)))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 221, in deserialize
    return Proof(
           ^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 188, in __init__
    self.limitedid = LimitedProofId.build(
                     ^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 136, in build
    ss += serialize_sequence(stakes)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/serialize.py", line 128, in serialize_sequence
    b += obj.serialize()
         ^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 96, in serialize
    assert self.pubkey
AssertionError

======================================================================
FAIL: test_proofid (electrumabc.tests.test_avalanche.TestAvalancheProofFromHex.test_proofid)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/work/electrum/electrumabc/tests/test_avalanche.py", line 388, in test_proofid
    proof = Proof.from_hex(
            ^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/serialize.py", line 58, in from_hex
    return cls.deserialize(BytesIO(bytes.fromhex(hex_str)))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 221, in deserialize
    return Proof(
           ^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 188, in __init__
    self.limitedid = LimitedProofId.build(
                     ^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 136, in build
    ss += serialize_sequence(stakes)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/serialize.py", line 128, in serialize_sequence
    b += obj.serialize()
         ^^^^^^^^^^^^^^^
  File "/work/electrum/electrumabc/avalanche/proof.py", line 96, in serialize
    assert self.pubkey
AssertionError

----------------------------------------------------------------------
Ran 334 tests in 42.445s

FAILED (failures=4, errors=5, skipped=4)
Testing `setup.py --version`: OK

ninja: build stopped: cannot make progress due to previous errors.
Build electrum-tests failed with exit code 1
Fabien updated this revision to Diff 52432.Wed, Jan 29, 15:00

Fix the tests

Harbormaster completed remote builds in B32248: Diff 52432.Wed, Jan 29, 15:02
PiRK added a subscriber: PiRK.Fri, Jan 31, 12:45
PiRK added inline comments.
electrum/electrumabc/avalanche/proof.py
284 ↗(On Diff #52432)

Optional[AbstractWallet]?

electrum/electrumabc/tests/test_avalanche.py
227 ↗(On Diff #52432)

Wrong indentation? I think the test is doing nothing at the moment.

PiRK added inline comments.Fri, Jan 31, 13:12
electrum/electrumabc_gui/qt/main_window.py
956–964 ↗(On Diff #52432)

Is this supposed to dynamically enable the menu action when the device is initialized and the firmware version is known? Or just delay the decision until the time the menu is shown the first time, in the hope that at this time the firmware version number is known?

At the moment it can just disable the tools, not enable it if necessary.

PiRK added inline comments.Fri, Jan 31, 13:19
electrum/electrumabc_plugins/trezor/clientbase.py
283 ↗(On Diff #52432)

PublicKey.keydata is already used publicly in other places (e.g. DelegationEditor), so the round trip to/from hex is not necessary.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
avalanche/
119 lines
35 lines
36 lines
electrumabc_gui/
qt/
avalanche/
82 lines
17 lines
electrumabc_plugins/
hw_wallet/
4 lines
trezor/
24 lines
32 lines

Diff 52336

View Options

electrum/electrumabc/avalanche/proof.py

Loading...
View Options

electrum/electrumabc/keystore.py

Loading...
View Options

electrum/electrumabc/wallet.py

Loading...
View Options

electrum/electrumabc_gui/qt/avalanche/proof_editor.py

Loading...
View Options

electrum/electrumabc_gui/qt/main_window.py

Loading...
View Options

electrum/electrumabc_plugins/hw_wallet/qt.py

Loading...
View Options

electrum/electrumabc_plugins/trezor/clientbase.py

Loading...
View Options

electrum/electrumabc_plugins/trezor/trezor.py

Loading...