Differential D17604

[cmake] Fix check-crates
ClosedPublic
Actions

Authored by Fabien on Tue, Jan 28, 15:47.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCb6929f58a136: [cmake] Fix check-crates

Summary

The check-crates target uses wildcards and is catching all the bitcoinsuite-* crates from the workspace, which triggers the integration tests for bitcoinsuite-chronik-client. This is undesired behavior so let's not do this.

Test Plan

ninja check-crates

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Tue, Jan 28, 15:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jan 28, 15:47

Fabien requested review of this revision.Tue, Jan 28, 15:47

@bot build-chronik

teamcity awarded a token.Tue, Jan 28, 15:47

PiRK accepted this revision.Tue, Jan 28, 15:53

This revision is now accepted and ready to land.Tue, Jan 28, 15:53

Harbormaster completed remote builds in B32243: Diff 52425.Tue, Jan 28, 16:11

Closed by commit rABCb6929f58a136: [cmake] Fix check-crates (authored by Fabien). · Explain WhyTue, Jan 28, 16:18

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCb6929f58a136: [cmake] Fix check-crates.

Revision Contents
Changeset List

Path

Size

chronik/

CMakeLists.txt

17 lines

Diff 52426

View Options

[cmake] Fix check-cratesClosedPublicActions