This is used to hash a "seed" from a mnemonic (seed phrase).
Depends on D17609.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC01abe1438cf6: [ecash-lib] Add `pbkdf2`
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| modules/ecash-lib/src/pbkdf2.test.ts | ||
|---|---|---|
| 32 ↗ | (On Diff #52442) | this matches the test result in https://github.com/paulmillr/noble-hashes/blob/main/test/kdf.test.js |
| 37 ↗ | (On Diff #52442) | it looks like this does not match the result from https://github.com/paulmillr/noble-hashes/blob/main/test/kdf.test.js is this expected? https://github.com/paulmillr/noble-hashes/blob/main/test/kdf.test.js#L163 |
| modules/ecash-lib/src/pbkdf2.test.ts | ||
|---|---|---|
| 37 ↗ | (On Diff #52442) | oh, here I reduced the number of iterations from 80000 to 8000 the test would run for 1200ms otherwise—if that's fine I can bump it, or change it to a iteration count that's not so similar. I suspect the solution here is not as optimized as the the one from noble. Maybe we should move it to Rust entirely (but maybe not now) |