Page MenuHomePhabricator

[Cashtab] Always show send button on send screen
ClosedPublic

Authored by bytesofman on Sat, Feb 1, 23:16.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCe27f29ba4083: [Cashtab] Always show send button on send screen
Summary

T3724

Make sure the Send button is always visible. User can still scroll to review tx.

Test Plan

npm test

check out the test site to see how it looks / works

https://cashtab-local-dev.netlify.app/

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sendbtn-always-on-top
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32288
Build 64066: Build Diffcashtab-tests
Build 64065: arc lint + arc unit

Event Timeline

bytesofman published this revision for review.Sat, Feb 1, 23:48

version bump + extension bump

emack requested changes to this revision.Sun, Feb 2, 05:00
emack added a subscriber: emack.

On extension the Send button is aligned left, which is correct but the rest of the component is overflowing off to the right as per current behavior. Makes the Send button almost look like a pop up not to mention it covers the labels beneath it.

image.png (1×627 px, 99 KB)

This revision now requires changes to proceed.Sun, Feb 2, 05:00

give button container background color so scroll-behind looks cleaner, line it up with app buttons on mobile

On extension the Send button is aligned left, which is correct but the rest of the component is overflowing off to the right as per current behavior. Makes the Send button almost look like a pop up not to mention it covers the labels beneath it.

image.png (1×627 px, 99 KB)

looks like there is an existing issue here for this browser / device

improvements made in response to this feedback should help this, but the cutting off of the right-width is a separate thing -- looks like it's opening with a width less than 320px.

what is the browser / device here?

brave browser desktop opens the extension at full height, right side of screen, looks good, e.g.

image.png (960×445 px, 78 KB)

what is the browser / device here?

Ubuntu 22.04 / Chrome 125.0.6422.112

This revision is now accepted and ready to land.Mon, Feb 3, 01:43