[electrum] freeze UTXOs that may contain ALP tokens
Needs RevisionPublic
Actions

Authored by PiRK on Tue, Mar 11, 17:21.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Summary

This makes ALP tokens unspendable.

We add a data structure to store outpoints that may be ALP tokens. For now, the detection logic is very basic: we freeze all outputs in any transaction whose first output is a valid EMPP output with at least one payload that starts with the ALP lokad ID.

A known drawback is that this method makes the change output also unspendable (for users who import a seed from a token wallet such as CashTab into Electrum ABC). Future improvements should be to:

make it possible for users to force-spend SLP, ALP and false positive ALP outputs if they insist
properly parse ALP tokens to eliminate these known false positives

Test Plan

Open a wallet that already has an ALP token, make sure that now it is frozen and show as a potential token (green background) in the coins tab.

Send a new alp token to the wallet, make sure it gets frozen and green.

python test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

alp

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32665
Build 64818: Build Diff	electrum-tests
Build 64817: arc lint + arc unit

Event Timeline

PiRK created this revision.Tue, Mar 11, 17:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Mar 11, 17:21

Harbormaster completed remote builds in B32659: Diff 53018.Tue, Mar 11, 17:23

add unittests

PiRK published this revision for review.Tue, Mar 11, 19:56

Harbormaster completed remote builds in B32665: Diff 53024.Tue, Mar 11, 19:57

PiRK edited the summary of this revision. (Show Details)Tue, Mar 11, 20:50

PiRK edited the test plan for this revision. (Show Details)

minor UI improvement (change the greyed out spend action text to tell why the coin is unspendable)

Harbormaster completed remote builds in B32668: Diff 53027.Tue, Mar 11, 21:01

Fabien requested changes to this revision.Wed, Mar 12, 13:24

Fabien added a subscriber: Fabien.

Fabien added inline comments.

electrum/electrumabc/tests/test_alp.py
1 ↗	(On Diff #53027)	The header is missing
electrum/electrumabc/tokens/alp.py
57 ↗	(On Diff #53027)	The comment could be a docstring
80 ↗	(On Diff #53027)	my understanding is that the other outputs can't be tokens or this makes the tx an invalid empp: A valid eMPP tx must have an OP_RETURN output at the first (vout = 0) position. Any OP_RETURN at a position after that should be ignored as invalid.