Page MenuHomePhabricator
Differential D17774

[ecash-lib-wasm] Add readme with installation instructions
ClosedPublic
Actions

Authored by emack on Tue, Mar 11, 04:53.

Details

Reviewers
bytesofman
Fabien
Group Reviewers
Restricted Project
Commits
rABCd366dd0addf2: [ecash-lib-wasm] Add readme with installation instructions
Summary

I've fielded a few questions now on how to resolve the wasm related dependency errors when trying to run Cashtab after some of the dependency modules have been updated.

This is the only repo without a readme - add one.

Test Plan

Plonk into https://jbt.github.io/markdown-editor/ and proof read

Diff Detail

Event Timeline

emack created this revision.Tue, Mar 11, 04:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Mar 11, 04:53
emack requested review of this revision.Tue, Mar 11, 04:53
Harbormaster completed remote builds in B32648: Diff 53006.Tue, Mar 11, 05:02
bytesofman requested changes to this revision.Tue, Mar 11, 13:14
bytesofman added inline comments.
modules/ecash-lib-wasm/README.md
7 ↗(On Diff #53006)

better to just link to a site with this and avoid specific scripted instructions for docker installation in this README.

these install instructions are likely to change / vary for different systems

we do not want to maintain docker installation steps in the ecash-lib-wasm repo

This revision now requires changes to proceed.Tue, Mar 11, 13:14
emack updated this revision to Diff 53066.Thu, Mar 13, 06:01
emack marked an inline comment as done.

Linked docker installation guide

Harbormaster completed remote builds in B32699: Diff 53066.Thu, Mar 13, 06:08
Fabien added a subscriber: Fabien.Thu, Mar 13, 08:38
Fabien added inline comments.
modules/ecash-lib-wasm/README.md
5 ↗(On Diff #53066)

It doesn't install ecash-lib-wasm

14 ↗(On Diff #53066)

What about the build without docker ?

Fabien requested changes to this revision.Thu, Mar 13, 08:38
This revision now requires changes to proceed.Thu, Mar 13, 08:38
emack updated this revision to Diff 53107.Fri, Mar 14, 05:19

Updated readme

Harbormaster completed remote builds in B32724: Diff 53107.Fri, Mar 14, 05:30
bytesofman requested changes to this revision.Fri, Mar 14, 13:27
bytesofman added inline comments.
modules/ecash-lib-wasm/README.md
18 ↗(On Diff #53107)
This revision now requires changes to proceed.Fri, Mar 14, 13:27
emack updated this revision to Diff 53129.Sun, Mar 16, 00:30

updated readme

Harbormaster completed remote builds in B32738: Diff 53129.Sun, Mar 16, 00:40
bytesofman accepted this revision.Sun, Mar 16, 13:19
bytesofman added inline comments.
modules/ecash-lib-wasm/README.md
3 ↗(On Diff #53129)
emack updated this revision to Diff 53130.Sun, Mar 16, 13:29
emack marked an inline comment as done.

updated readme

Harbormaster completed remote builds in B32739: Diff 53130.Sun, Mar 16, 13:39
Fabien accepted this revision.Sun, Mar 16, 19:19
This revision is now accepted and ready to land.Sun, Mar 16, 19:19
Closed by commit rABCd366dd0addf2: [ecash-lib-wasm] Add readme with installation instructions (authored by emack). · Explain WhyMon, Mar 17, 01:30
This revision was automatically updated to reflect the committed changes.
emack added a commit: rABCd366dd0addf2: [ecash-lib-wasm] Add readme with installation instructions.

Revision Contents
Changeset List

PathSize
modules/
ecash-lib-wasm/
18 lines

Diff 53130

View Options

modules/ecash-lib-wasm/README.md

Loading...