Page MenuHomePhabricator
Differential D17824

[electrum] No python 3.12 syntax
ClosedPublic
Actions

Authored by Fabien on Wed, Mar 19, 10:24.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCaf031872bf01: [electrum] No python 3.12 syntax
Summary

The delete parameter of the TemporaryDirectory constructor has been introduced in python 3.12. Let's not use that.

Test Plan

Check updating to latest Trezor firmware still works.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
electrum_no_python_3.12
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32762
Build 65012: Build Diffelectrum-tests
Build 65011: arc lint + arc unit

Event Timeline

Fabien created this revision.Wed, Mar 19, 10:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Mar 19, 10:24
Fabien requested review of this revision.Wed, Mar 19, 10:24
Harbormaster completed remote builds in B32762: Diff 53169.Wed, Mar 19, 10:27
PiRK accepted this revision.Wed, Mar 19, 10:43
This revision is now accepted and ready to land.Wed, Mar 19, 10:43
Closed by commit rABCaf031872bf01: [electrum] No python 3.12 syntax (authored by Fabien). · Explain WhyWed, Mar 19, 11:44
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCaf031872bf01: [electrum] No python 3.12 syntax.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc_plugins/
trezor/
10 lines

Diff 53169

View Options

electrum/electrumabc_plugins/trezor/qt.py

Loading...