Differential D17838

[avalanche] Don't include validation.h via proof.h
ClosedPublic
Actions

Authored by Fabien on Thu, Mar 20, 09:27.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC12025bba2389: [avalanche] Don't include validation.h via proof.h

Summary

Lots of test files rely on this indirect inclusion which is bad. Remove the header from proof.h and update accordingly.

Depends on D17837.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_proof_no_validation_header

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32786
Build 65060: Build Diff	lint-circular-dependencies · build-without-wallet · build-debug · build-clang-tidy · build-clang · build-diff
Build 65059: arc lint + arc unit

Event Timeline

Fabien created this revision.Thu, Mar 20, 09:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Mar 20, 09:27

Fabien requested review of this revision.Thu, Mar 20, 09:27

PiRK accepted this revision.Thu, Mar 20, 09:35

This revision is now accepted and ready to land.Thu, Mar 20, 09:35

Harbormaster completed remote builds in B32786: Diff 53201.Thu, Mar 20, 09:39

Closed by commit rABC12025bba2389: [avalanche] Don't include validation.h via proof.h (authored by Fabien). · Explain WhyThu, Mar 20, 13:09

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC12025bba2389: [avalanche] Don't include validation.h via proof.h.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

proof.h

3 lines

proof.cpp

1 line

test/

compactproofs_tests.cpp

1 line

delegation_tests.cpp

1 line

processor_tests.cpp

1 line

proofcomparator_tests.cpp

1 line

proofpool_tests.cpp

1 line

stakecontendercache_tests.cpp

1 line

stakingrewards_tests.cpp

1 line

util.h

2 lines

Diff 53201

View Options

src/avalanche/proof.h

View Options

src/avalanche/proof.cpp

View Options

src/avalanche/test/compactproofs_tests.cpp

View Options

src/avalanche/test/delegation_tests.cpp

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/avalanche/test/proofcomparator_tests.cpp

View Options

src/avalanche/test/proofpool_tests.cpp

View Options

src/avalanche/test/stakecontendercache_tests.cpp

View Options

src/avalanche/test/stakingrewards_tests.cpp

View Options

[avalanche] Don't include validation.h via proof.hClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 53201

src/avalanche/proof.h

src/avalanche/proof.cpp

src/avalanche/test/compactproofs_tests.cpp

src/avalanche/test/delegation_tests.cpp

src/avalanche/test/processor_tests.cpp

src/avalanche/test/proofcomparator_tests.cpp

src/avalanche/test/proofpool_tests.cpp

src/avalanche/test/stakecontendercache_tests.cpp

src/avalanche/test/stakingrewards_tests.cpp

src/avalanche/test/util.h

[avalanche] Don't include validation.h via proof.h
ClosedPublic
Actions

Revision Contents
Changeset List