Differential D17840

[avalanche] Fix flaky proof rank comparison in processor_tests
ClosedPublic
Actions

Authored by roqqit on Thu, Mar 20, 17:04.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4271d8338029: [avalanche] Fix flaky proof rank comparison in processor_tests

Summary

If two proofs have the same rank, this test breaks because one of the proofs is not marked as accepted like it should be.

Test Plan

for I in {0..100}; do ninja check-avalanche-processor_tests || break ; done

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sc-flaky-test-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32789
Build 65066: Build Diff	build-without-wallet · lint-circular-dependencies · build-clang-tidy · build-clang · build-debug · build-diff
Build 65065: arc lint + arc unit

Event Timeline

roqqit created this revision.Thu, Mar 20, 17:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Mar 20, 17:04

roqqit requested review of this revision.Thu, Mar 20, 17:04

Harbormaster completed remote builds in B32789: Diff 53208.Thu, Mar 20, 17:13

Fabien accepted this revision.Thu, Mar 20, 19:45

This revision is now accepted and ready to land.Thu, Mar 20, 19:45

Closed by commit rABC4271d8338029: [avalanche] Fix flaky proof rank comparison in processor_tests (authored by roqqit). · Explain WhyFri, Mar 21, 14:54

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABC4271d8338029: [avalanche] Fix flaky proof rank comparison in processor_tests.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

processor_tests.cpp

2 lines

Diff 53208

View Options

src/avalanche/test/processor_tests.cpp

[avalanche] Fix flaky proof rank comparison in processor_testsClosedPublicActions