Page MenuHomePhabricator
Differential D17842

[electrum] Alllow for downgrading the Trezor firmware
ClosedPublic
Actions

Authored by Fabien on Fri, Mar 21, 09:55.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCea7437f90053: [electrum] Alllow for downgrading the Trezor firmware
Summary

When the user selects to install a custom firmware, Electrum detects whether it's an official firmware and applies some checks on the header including a version check that prevents from downgrading the firmware. This is not the expected behavior when the firmware is installed from a file and the user should be able to downgrade if desired.

Test Plan

Downgrade an official Trezor firmware using this method.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
electrum_downgrade_trezor
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32794
Build 65076: Build Diffelectrum-tests
Build 65075: arc lint + arc unit

Event Timeline

Fabien created this revision.Fri, Mar 21, 09:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Mar 21, 09:55
Fabien requested review of this revision.Fri, Mar 21, 09:55
Harbormaster completed remote builds in B32794: Diff 53216.Fri, Mar 21, 09:58
PiRK accepted this revision.Fri, Mar 21, 10:05
PiRK added a subscriber: PiRK.
PiRK added inline comments.
electrum/electrumabc_plugins/trezor/clientbase.py
470
This revision is now accepted and ready to land.Fri, Mar 21, 10:05
Closed by commit rABCea7437f90053: [electrum] Alllow for downgrading the Trezor firmware (authored by Fabien). · Explain WhyFri, Mar 21, 10:06
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCea7437f90053: [electrum] Alllow for downgrading the Trezor firmware.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc_plugins/
trezor/
10 lines
6 lines

Diff 53216

View Options

electrum/electrumabc_plugins/trezor/clientbase.py

Loading...
View Options

electrum/electrumabc_plugins/trezor/qt.py

Loading...