Differential D17843

[electrum] Increase the timeout for entering the bootloader mode
ClosedPublic
Actions

Authored by Fabien on Fri, Mar 21, 10:04.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC399c09a28574: [electrum] Increase the timeout for entering the bootloader mode

Summary

Bump from 30s to 60s. 30s can be a bit short on windows where the USB connection takes time, plus the time the user has to wait for the screen to become responsive and figure out where to click.

Test Plan

Run an upgrade.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

electrum_bump_trezor_timeout

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32795
Build 65078: Build Diff	electrum-tests
Build 65077: arc lint + arc unit

Event Timeline

Fabien created this revision.Fri, Mar 21, 10:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Mar 21, 10:04

Fabien requested review of this revision.Fri, Mar 21, 10:04

Harbormaster completed remote builds in B32795: Diff 53217.Fri, Mar 21, 10:06

translation nit

electrum/electrumabc_plugins/trezor/clientbase.py
356–360	If we ever want to restart a translation project, the placeholder string should be without the timeout

This revision is now accepted and ready to land.Fri, Mar 21, 10:09

Closed by commit rABC399c09a28574: [electrum] Increase the timeout for entering the bootloader mode (authored by Fabien). · Explain WhyFri, Mar 21, 10:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC399c09a28574: [electrum] Increase the timeout for entering the bootloader mode.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc_plugins/

trezor/

clientbase.py

12 lines

Diff 53217

View Options

electrum/electrumabc_plugins/trezor/clientbase.py

[electrum] Increase the timeout for entering the bootloader modeClosedPublicActions