qt: clean up initialize/shutdown signals
ClosedPublic
Actions

Authored by jasonbcox on Oct 9 2018, 03:10.

Details

Reviewers

deadalnix
schancel

Group Reviewers

Restricted Project

Commits

rSTAGING8982b9d3519d: qt: clean up initialize/shutdown signals
rABC8982b9d3519d: qt: clean up initialize/shutdown signals

Summary

Change initializeResult(int) to initializeResult(bool) to avoid implicit type conversion.
Use EXIT_FAILURE and EXIT_SUCCESS instead of magic numbers.
Remove the argument from shutdownResult(int); it was called with a constant argument.

Backport of https://github.com/bitcoin/bitcoin/pull/9834

Completes T427

Co-authored-by: Jason B. Cox <contact@jasonbcox.com>

Test Plan

make check && test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr9834

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3543
Build 5162: Bitcoin ABC Buildbot (legacy)
Build 5161: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 9 2018, 03:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 9 2018, 03:10

jasonbcox edited the summary of this revision. (Show Details)Oct 9 2018, 03:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3543: Diff 5328.Oct 9 2018, 03:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Oct 9 2018, 15:17

This revision is now accepted and ready to land.Oct 9 2018, 15:17

Closed by commit rABC8982b9d3519d: qt: clean up initialize/shutdown signals (authored by Marko Bencun <marko.bencun@monetas.net>, committed by jasonbcox). · Explain WhyOct 9 2018, 16:58

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoin.cpp

33 lines

Diff 5328

View Options

qt: clean up initialize/shutdown signalsClosedPublicActions